⚓ T372643 forceeditsummary no longer prompting in ns:2
Page MenuHomePhabricator
Create Task
Maniphest T372643

forceeditsummary no longer prompting in ns:2
Closed, InvalidPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Log on
  • Set "Prompt me when entering a blank edit summary (or the default undo summary)" to true in prefernces
  • Make a contribution in namesapce 2 (user talk) leaving the edit summary blank

What happens?:

  • The contribution is published

What should have happened instead?:

  • The publish should have been interrupted with a confirmation prompt

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
WMF Production

Other information (browser name/version, screenshots, etc.):
Sample contribution: https://test.wikipedia.org/w/index.php?title=User_talk:Xaosflux&diff=prev&oldid=608684

Originally reported on enwiki VPT ( https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1240638074#%22Prompt_me_when_entering_a_blank_edit_summary_%28or_the_default_undo_summary%29%22_preference_did_not_work_for_me_just_now )

Related Objects

Event Timeline

Xaosflux created this task.Aug 16 2024, 1:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2024, 1:52 PM
Xaosflux added a project: MediaWiki-Page-editing.Aug 16 2024, 1:53 PM
Xaosflux renamed this task from "Prompt me when entering a blank edit summary (or the default undo summary)" no longer prompting to "Prompt me when entering a blank edit summary (or the default undo summary)" no longer prompting in ns:2.Aug 16 2024, 1:57 PM
Xaosflux updated the task description. (Show Details)
Xaosflux updated the task description. (Show Details)
Xaosflux renamed this task from "Prompt me when entering a blank edit summary (or the default undo summary)" no longer prompting in ns:2 to forceeditsummary no longer prompting in ns:2.Aug 16 2024, 2:02 PM
Jonesey95 subscribed.Aug 16 2024, 5:03 PM
matmarex subscribed.Aug 16 2024, 6:17 PM

There is a special case in the code checking summaries, described as "Don't force edit summaries when a user is editing their own user or talk page":
https://gerrit.wikimedia.org/g/mediawiki/core/+/3831d53eb9ca5091be622aa68b1b21eda848bf4e/includes/editpage/EditPage.php#1307

It has been there since 2006: https://static-codereview.wikimedia.org/MediaWiki/13596.html / rSVN13596 / 10a02241999428f7a866f1d38743172ecfc435a0

I don't think this is a regression. It may be worth discussing changing this behavior, but folks might be upset by that too. Maybe someone could cook up some SQL queries to see if users who enabled that preference take advantage of not having to fill in summaries in their user and talk pages.

Xaosflux removed a project: Regression.Aug 16 2024, 10:16 PM

Thank you for the update, regression marker withdrawn. Updated the documentation at https://www.mediawiki.org/wiki/Help:Preferences#Editing

Xaosflux closed this task as Invalid.Aug 16 2024, 10:17 PM
Xaosflux claimed this task.

Not a bug, existing feature, updated documentation.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits