That's a great idea @Volker_E , let's pursue that for now since it would be much easier and faster than doing it properly (which we can always do later).

A few things I noticed while trying this out:

• We would need additional :not()s for the warning, error and success variants (these are less common, but some icons appear to have them, at least in the OOUI icon defs)
• This covers icons, but not indicators. That's easy to fix though, just add .oo-ui-indicatorElement-indicator to the selector (I don't think the :not()s should be needed since indicators don't seem to have variants other than invert)
• Checkboxes use a combination of an icon class and a background color, which results in them being inverted to yellow:
  

Those all seem fixable though. The checkbox one looks annoying but I'm sure we can figure something out.

Yeah, I was too lazy before to add the -indicator and error, warning and success selectors before into that POC example. It's great to limit to -indicator only, that's handy.
The OOUI CheckboxWidget, as it mixes the widget class and the icon class onto the same element could either be handled as
:not( .oo-ui-checkboxInputWidget-checkIcon ) or as :not( .oo-ui-widget.oo-ui-icon-check )

We could also combine this rule with another selector to help Vector:

.vector-dropdown .vector-dropdown-label:not(.cdx-button--icon-only)::after {}

Resulting in code:

.oo-ui-iconElement-icon:not( .oo-ui-image-progressive ):not( .oo-ui-image-destructive ):not( .oo-ui-checkboxInputWidget-checkIcon ), 
.oo-ui-indicatorElement-indicator,
.vector-dropdown .vector-dropdown-label:not(.cdx-button--icon-only)::after {
    filter: invert( 1 ) !important;
}

For readability it might be preferable to undo the filtering on error, warning, success, maybe also destructive and progressive.

Apart from Notifications, that looks pretty good on Special:Preferences and Special:RecentChanges. It might not even need the !important depending on where the style module would be loaded. Only a special treatment for the filter icons on RCFilters were needed.

Special:RecentChanges:

I was thinking of this issue myself today, the approach that I initially thought of was to use the .skin-invert class on all OOUI icons (in both PHP and JS). That approach is similar to what @Volker_E suggests, but instead of hardcoding the invert, it uses a class instead. I created a patch for what that would look like here: https://gerrit.wikimedia.org/r/c/oojs/ui/+/1037102 . The .skin-invert class would produce slightly incorrect colors for colored icons in dark-mode, but it would at least flip black icons to white.

In T365764#9843340, @Jdrewniak wrote:

I was thinking of this issue myself today, the approach that I initially thought of was to use the .skin-invert class on all OOUI icons (in both PHP and JS). That approach is similar to what @Volker_E suggests, but instead of hardcoding the invert, it uses a class instead. I created a patch for what that would look like here: https://gerrit.wikimedia.org/r/c/oojs/ui/+/1037102 . The .skin-invert class would produce slightly incorrect colors for colored icons in dark-mode, but it would at least flip black icons to white.

If we can use an existing class (and apply it directly within OOUI) to apply this fix, then even better. We are okay with slightly incorrect colors as long as things are legible.

Change #1037102 had a related patch set uploaded (by Eric Gardner; author: Jdrewniak):

[oojs/ui@master] [WIP] Add `.skin-invert` class to OOUI icons

https://gerrit.wikimedia.org/r/1037102

Change #1038415 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/MinervaNeue@master] styles: Apply inversion on certain OOUI icons and indicators

https://gerrit.wikimedia.org/r/1038415

Change #1038418 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Apply inversion on certain OOUI icons and indicators

https://gerrit.wikimedia.org/r/1038418

Change #1038910 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Use mask-image for all Vector icons

https://gerrit.wikimedia.org/r/1038910

Change #1038911 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] POC: Support mask-image in ResourceLoader ImageModule

https://gerrit.wikimedia.org/r/1038911

Change #1038914 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Icons render consistently in night mode

https://gerrit.wikimedia.org/r/1038914

Change #1038918 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] VisualEditor toolbar should use notheme

https://gerrit.wikimedia.org/r/1038918

I took some time to think about this and write some things down and try out a few proof of concepts, but as I understand it the main thing DST team needs from the web team right now is clarity on what it needs to deliver. I've created T366709 for making that decision.

Change #1038918 merged by jenkins-bot:

[mediawiki/skins/Vector@master] VisualEditor toolbar should use notheme

https://gerrit.wikimedia.org/r/1038918

Just to provide an update:
The web team is discussing different solutions to this problem internally. Once we feel like we have agreement on our preferred approach we will reach out to the DST team to discuss this. In the mean time the DST should not concern itself with making icons work correctly in the night theme (but is welcome to explore any ideas they might have for when we have that discussion!).

[FYI] The patch merged above was a defensive patch to make sure VisualEditor toolbar uses the light theme for now, by adding the notheme class (which is what we do for other elements in the page) so that we can opt into the night theme when we are ready.

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/312e23eb6f/w

Also created an OOUI Demos page:
https://patchdemo.wmflabs.org/wikis/312e23eb6f/w/build/ooui/demos

Change #1037102 abandoned by VolkerE:

[oojs/ui@master] [WIP] Add `.skin-invert` class to OOUI icons

Reason:

Abandoned for Web team taking the lead here. Could be resurrected in case.

https://gerrit.wikimedia.org/r/1037102

Change #1038415 abandoned by VolkerE:

[mediawiki/skins/MinervaNeue@master] styles: Apply inversion on certain OOUI icons and indicators

Reason:

Abandoned for Web team taking the lead here. Could be resurrected in case.

https://gerrit.wikimedia.org/r/1038415

Change #1038418 abandoned by VolkerE:

[mediawiki/skins/Vector@master] styles: Apply inversion on certain OOUI icons and indicators

Reason:

Abandoned for Web team to take the lead here. Can be resurrected if needed.

https://gerrit.wikimedia.org/r/1038418

Change #1038418 restored by Jdrewniak:

[mediawiki/skins/Vector@master] styles: Apply inversion on certain OOUI icons and indicators

https://gerrit.wikimedia.org/r/1038418

Change #1038415 restored by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] styles: Apply inversion on certain OOUI icons and indicators

https://gerrit.wikimedia.org/r/1038415

I'm reviewing the impact of this change, and I can see various regressions that will be caused by merging this fix. Before merging I'll double check with the team, about how to handle those tickets.
There are several significant side effects of merging these changes that need to be considered:

• Breakages to map icons in some places
• Breakages to Phonos in some places
• Breakage in certain editors (non VisualEditor)

Change #1038418 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Apply inversion on certain OOUI icons and indicators

https://gerrit.wikimedia.org/r/1038418

Change #1038415 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] styles: Apply inversion on certain OOUI icons and indicators

https://gerrit.wikimedia.org/r/1038415

The following regressions were caused directly by this change:

• T367373
• T367362

There are likely more we don't know about.
I'm assuming the exploratory QA in T365383 will find some and act as QA for this task, so this task skips QA.

Change #1043122 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Separate out indicator and icon sizes

https://gerrit.wikimedia.org/r/1043122

Change #1043122 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Separate out indicator and icon selectors

https://gerrit.wikimedia.org/r/1043122

Change #1043818 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Followup to 71c532e Separate out indicator and icon selectors

https://gerrit.wikimedia.org/r/1043818

Change #1043818 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Followup to 71c532e Separate out indicator and icon selectors

https://gerrit.wikimedia.org/r/1043818

Change #1038914 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Icons render consistently in night mode

Reason:

We will talk to the Design Systems Team about this potential solution tomorrow.

https://gerrit.wikimedia.org/r/1038914

Change #1038910 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

Reason:

To be discussed with DST on Tuesday June 18th

https://gerrit.wikimedia.org/r/1038910

Change #1038911 abandoned by Jdlrobson:

[mediawiki/core@master] POC: Support mask-image in ResourceLoader ImageModule

Reason:

My understand is Jan spoke to DST about this. Let me know if this patch is useful and when you would have capacity to work on and I can restore it then if needed.

https://gerrit.wikimedia.org/r/1038911

Change #1038911 restored by Jdlrobson:

[mediawiki/core@master] POC: Support mask-image in ResourceLoader ImageModule

https://gerrit.wikimedia.org/r/1038911

Change #1038910 restored by Jdlrobson:

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

https://gerrit.wikimedia.org/r/1038910

Change #1038911 merged by jenkins-bot:

[mediawiki/core@master] Support mask-image in ResourceLoader ImageModule

https://gerrit.wikimedia.org/r/1038911

Change #1038914 restored by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Icons render consistently in night mode

https://gerrit.wikimedia.org/r/1038914