⚓ T363525 Community Configuration edit form: protected / read only view
Page MenuHomePhabricator

Community Configuration edit form: protected / read only view
Closed, ResolvedPublic3 Estimated Story Points

Description

User Story:

As a logged out users or logged in non-admin, I want to be able to view configuration options and understand I can't edit the form, because Community Configuration is a protected form that is only editable by admins.

Details

All logged in and logged out accounts should have access to view the Community Configuration dashboard and forms.

When a non-admin accesses Special:CommunityConfiguration, they should see it in a non-active state (as they are not actually able to Save changes and update the configuration). We still want non-admins to be able to see the configuration (and all configuration options), similarly to Special:EditGrowthConfig in GrowthExperiments.

Design

Form:

  • Switching from a Warning message to a Notice message.
  • We are also disabling the 'Save changes' button only so non-admins can still play around with the different options and see the different values but not being able to save any changes.
  • Add an inline message on top of the button. See example screenshot:

Ex. mentorship form is protected (1).png (1×1 px, 153 KB)

Acceptance Criteria

Given I'm logged out or logged in as a non-Admin,
When I access a Community Configuration form,
Then the form is clearly inactive and I'm unable to edit it.

Given I'm logged in as an admin,
When I access a Community Configuration form,
Then the form is clearly active and I can edit it.

Event Timeline

When a non-admin user goes to Special:CommunityConfiguration and selects a provider to edit, they are unable to change any of the form fields

As far as I understand, this is what has been discarded, as it’s impossible to do in an accessible manner (unchangeable radio buttons, checkboxes etc. are not read aloud by screen readers).

Thanks, @Tacsipacsi, for noticing that. I've updated the language. (I had copied some of the outdated text from the previous design task).

Non-admins will be able to change form fields, they just won't be able to save those changes.

KStoller-WMF renamed this task from Community Configuration edit from: protected / read only view to Community Configuration edit form: protected / read only view.May 1 2024, 6:14 PM
KStoller-WMF raised the priority of this task from Medium to High.May 8 2024, 4:55 PM
Urbanecm_WMF set the point value for this task to 3.May 14 2024, 4:28 PM

Change #1032480 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/CommunityConfiguration@master] Add admin status check and notice message to Community Configuration form

https://gerrit.wikimedia.org/r/1032480

Change #1032480 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Add permissions check and notice messages

https://gerrit.wikimedia.org/r/1032480

Checked in betalabs - moved for @JFernandez-WMF review.

The notice message is placed after the info text; the mockup in the task description displays the notice message right after the link to Special:CommunityConfiguration page:

betalabs
{F55033207}

Otherwise, the functionality is in place and the inline message looks and behaves as expected.

Adding screenshots for mobile - the title that follows immediately after the notice message has a decreased font size. @JFernandez-WMF - let me know if an additional task should be filed for this issue on mobile.

Screen Shot 2024-06-07 at 3.39.51 PM.png (1×734 px, 208 KB)