⚓ T360664 Stop using, deprecate, and then remove various static ChangeTags methods moved to ChangeTagsStore
Page MenuHomePhabricator
Create Task
Maniphest T360664

Stop using, deprecate, and then remove various static ChangeTags methods moved to ChangeTagsStore
Open, Needs TriagePublic
Actions

Description

List:

  • ::getSoftwareTags()
  • ::addTags()
  • ::updateTags()
  • ::getTagsWithData()
  • ::getTags()
  • ::modifyDisplayQuery()
  • ::makeTagSummarySubquery()
  • ::defineTag()
  • ::deleteTagEverywhere()
  • ::listSoftwareActivatedTags()
  • ::listDefinedTags()
  • ::listExplicitlyDefinedTags()
  • ::listSoftwareDefinedTags()
  • ::purgeTagCacheAll()
  • ::tagUsageStatistics()
  • ::getDisplayTableName()

Actions:

  • Soft deprecate: in b5ccd131d6f0a4982510e1ce160accdd5d5938af for T245964
  • Replace uses in Wikimedia-deployed code:
    • MediaWiki core
    • mediawiki/extensions/AbuseFilter
    • mediawiki/extensions/ContentTranslation
    • mediawiki/extensions/DiscussionTools
    • mediawiki/extensions/EventBus
    • mediawiki/extensions/FileImporter
    • mediawiki/extensions/GrowthExperiments
    • mediawiki/extensions/MachineVision
    • mediawiki/extensions/MassMessage
    • mediawiki/extensions/MobileApp
    • mediawiki/extensions/MobileFrontend
    • mediawiki/extensions/ProofreadPage
    • mediawiki/extensions/WikiLove
    • mediawiki/extensions/Wikibase
    • mediawiki/extensions/WikibaseLexeme
    • mediawiki/extensions/WikimediaEditorTasks
  • Hard-deprecate (done in MW 1.44
  • Replace most uses in ecosystem-wide code
  • Remove, at earliest in MW 1.45

Details

SubjectRepoBranchLines +/-
ChangeTags: Hard-deprecate methods deprecated in 1.41mediawiki/coremaster+88 -50
Inject ChangeTagsStore into Api(Content|Section)TranslationPublishmediawiki/extensions/ContentTranslationmaster+20 -13
Replace use of deprecated ChangeTags::addTags() and ::listSoftwareActivatedTags()mediawiki/extensions/ContentTranslationmaster+14 -5
Replace use of deprecated ChangeTags::addTags(), getTags(), ::getTagsWithData(), and ::updateTags()mediawiki/extensions/GrowthExperimentsmaster+34 -18
Replace uses of deprecated ChangeTags static methodsmediawiki/coremaster+98 -60
Replace use of deprecated ChangeTags::getTags(), defineTag(), and listExplicitlyDefinedTags()mediawiki/extensions/Wikibasemaster+23 -25
Replace use of deprecated ChangeTags::getTags() and defineTag()mediawiki/extensions/WikibaseLexememaster+9 -6
Replace use of deprecated ChangeTags::getTags()mediawiki/extensions/FileImportermaster+4 -4
Replace use of deprecated ChangeTags::getTags()mediawiki/extensions/MobileFrontendmaster+6 -5
MassMessageJobTest: Replace use of deprecated ChangeTags::getTagsWithData()mediawiki/extensions/MassMessagemaster+1 -2
ApiWikiLove: Replace use of deprecated ChangeTags::addTags()mediawiki/extensions/WikiLovemaster+3 -2
MessageSender: Replace use of deprecated ChangeTags::addTags()mediawiki/extensions/MassMessagemaster+2 -3
Replace use of deprecated ChangeTags::getTags()mediawiki/extensions/ProofreadPagemaster+1 -2
Replace use of deprecated ChangeTags::getTags()mediawiki/extensions/MobileAppmaster+3 -2
Replace deprecated ChangeTags method calls with ChangeTagsStoremediawiki/extensions/DiscussionToolsmaster+2 -2
Replace deprecated ChangeTags method calls with ChangeTagStoremediawiki/extensions/AbuseFiltermaster+13 -12
Replace ChangeTags::*Tags() calls with ChangeTagStoremediawiki/extensions/WikimediaEditorTasksmaster+6 -4
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Mar 21 2024, 4:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2024, 4:22 PM
Jdforrester-WMF moved this task from Blocker to Deprecate or remove on the MW-1.43-release board.Mar 21 2024, 4:22 PM
Jdforrester-WMF moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.
gerritbot added a comment.Mar 21 2024, 4:27 PM

Change #1013320 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikimediaEditorTasks@master] Replace ChangeTags::*Tags() calls with ChangeTagStore

https://gerrit.wikimedia.org/r/1013320

gerritbot added a project: Patch-For-Review.Mar 21 2024, 4:27 PM
gerritbot added a comment.Mar 21 2024, 7:29 PM

Change #1013320 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEditorTasks@master] Replace ChangeTags::*Tags() calls with ChangeTagStore

https://gerrit.wikimedia.org/r/1013320

Jdforrester-WMF mentioned this in rEWETd53da7b632eb: Replace ChangeTags::*Tags() calls with ChangeTagStore.Mar 21 2024, 7:29 PM
Jdforrester-WMF updated the task description. (Show Details)Mar 21 2024, 7:54 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 21 2024, 8:00 PM
gerritbot added a comment.Mar 29 2024, 10:09 AM

Change #1015517 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/AbuseFilter@master] Replace deprecated ChangeTags method calls with ChangeTagStore

https://gerrit.wikimedia.org/r/1015517

gerritbot added a comment.Mar 29 2024, 6:58 PM

Change #1015517 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Replace deprecated ChangeTags method calls with ChangeTagStore

https://gerrit.wikimedia.org/r/1015517

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.25; 2024-04-02); removed MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 29 2024, 7:00 PM
matej_suchanek updated the task description. (Show Details)Mar 29 2024, 8:12 PM
gerritbot added a comment.Apr 1 2024, 1:01 AM

Change #1015655 had a related patch set uploaded (by 沈澄心; author: 沈澄心):

[mediawiki/extensions/DiscussionTools@master] Replace deprecated ChangeTags method calls with ChangeTagsStore

https://gerrit.wikimedia.org/r/1015655

Jdforrester-WMF updated the task description. (Show Details)Apr 1 2024, 11:04 AM
gerritbot added a comment.Apr 1 2024, 11:11 AM

Change #1015655 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Replace deprecated ChangeTags method calls with ChangeTagsStore

https://gerrit.wikimedia.org/r/1015655

Atieno added a parent task: T372295: Release MediaWiki 1.43.0.Aug 12 2024, 3:39 PM
Aklapper removed a parent task: T372295: Release MediaWiki 1.43.0.Aug 12 2024, 4:10 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 12 2024, 4:30 PM
gerritbot added a comment.Oct 15 2024, 10:23 PM

Change #1080385 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLove@master] ApiWikiLove: Replace use of deprecated ChangeTags::addTags()

https://gerrit.wikimedia.org/r/1080385

gerritbot added a project: Patch-For-Review.Oct 15 2024, 10:23 PM
gerritbot added a comment.Oct 15 2024, 10:27 PM

Change #1080389 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/MassMessage@master] MessageSender: Replace use of deprecated ChangeTags::addTags()

https://gerrit.wikimedia.org/r/1080389

gerritbot added a comment.Oct 15 2024, 10:28 PM

Change #1080390 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/MassMessage@master] MassMessageJobTest: Replace use of deprecated ChangeTags::getTagsWithData()

https://gerrit.wikimedia.org/r/1080390

gerritbot added a comment.Oct 15 2024, 10:46 PM

Change #1080398 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/GrowthExperiments@master] Replace use of deprecated ChangeTags::addTags(), getTags(), ::getTagsWithData(), and ::updateTags()

https://gerrit.wikimedia.org/r/1080398

gerritbot added a comment.Oct 15 2024, 11:00 PM

Change #1080401 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/ContentTranslation@master] Replace use of deprecated ChangeTags::addTags() and ::listSoftwareActivatedTags()

https://gerrit.wikimedia.org/r/1080401

gerritbot added a comment.Oct 15 2024, 11:02 PM

Change #1080402 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/ProofreadPage@master] Replace use of deprecated ChangeTags::getTags()

https://gerrit.wikimedia.org/r/1080402

gerritbot added a comment.Oct 15 2024, 11:04 PM

Change #1080403 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/MobileFrontend@master] Replace use of deprecated ChangeTags::getTags()

https://gerrit.wikimedia.org/r/1080403

gerritbot added a comment.Oct 15 2024, 11:06 PM

Change #1080404 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/MobileApp@master] Replace use of deprecated ChangeTags::getTags()

https://gerrit.wikimedia.org/r/1080404

gerritbot added a comment.Oct 15 2024, 11:09 PM

Change #1080406 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/FileImporter@master] Replace use of deprecated ChangeTags::getTags()

https://gerrit.wikimedia.org/r/1080406

gerritbot added a comment.Oct 15 2024, 11:16 PM

Change #1080407 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Wikibase@master] Replace use of deprecated ChangeTags::getTags(), defineTag(), and listExplicitlyDefinedTags()

https://gerrit.wikimedia.org/r/1080407

gerritbot added a comment.Oct 15 2024, 11:37 PM

Change #1080411 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikibaseLexeme@master] Replace use of deprecated ChangeTags::getTags() and defineTag()

https://gerrit.wikimedia.org/r/1080411

gerritbot added a comment.Oct 16 2024, 12:05 AM

Change #1080416 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Replace uses of deprecated ChangeTags static methods

https://gerrit.wikimedia.org/r/1080416

gerritbot added a comment.Oct 16 2024, 12:05 AM

Change #1080417 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ChangeTags: Hard-deprecate methods deprecated in 1.41

https://gerrit.wikimedia.org/r/1080417

gerritbot added a comment.Oct 16 2024, 12:21 AM

Change #1080404 merged by jenkins-bot:

[mediawiki/extensions/MobileApp@master] Replace use of deprecated ChangeTags::getTags()

https://gerrit.wikimedia.org/r/1080404

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Oct 16 2024, 1:00 AM
gerritbot added a comment.Oct 16 2024, 7:23 AM

Change #1080402 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Replace use of deprecated ChangeTags::getTags()

https://gerrit.wikimedia.org/r/1080402

gerritbot added a comment.Oct 16 2024, 3:37 PM

Change #1080389 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] MessageSender: Replace use of deprecated ChangeTags::addTags()

https://gerrit.wikimedia.org/r/1080389

gerritbot added a comment.Oct 16 2024, 3:52 PM

Change #1080385 merged by jenkins-bot:

[mediawiki/extensions/WikiLove@master] ApiWikiLove: Replace use of deprecated ChangeTags::addTags()

https://gerrit.wikimedia.org/r/1080385

gerritbot added a comment.Oct 16 2024, 3:52 PM

Change #1080390 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] MassMessageJobTest: Replace use of deprecated ChangeTags::getTagsWithData()

https://gerrit.wikimedia.org/r/1080390

gerritbot added a comment.Oct 16 2024, 4:02 PM

Change #1080401 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Replace use of deprecated ChangeTags::addTags() and ::listSoftwareActivatedTags()

https://gerrit.wikimedia.org/r/1080401

gerritbot added a comment.Oct 16 2024, 4:03 PM

Change #1080406 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Replace use of deprecated ChangeTags::getTags()

https://gerrit.wikimedia.org/r/1080406

gerritbot added a comment.Oct 16 2024, 4:03 PM

Change #1080403 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Replace use of deprecated ChangeTags::getTags()

https://gerrit.wikimedia.org/r/1080403

gerritbot added a comment.Oct 16 2024, 4:15 PM

Change #1080411 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Replace use of deprecated ChangeTags::getTags() and defineTag()

https://gerrit.wikimedia.org/r/1080411

gerritbot added a comment.Oct 16 2024, 5:22 PM

Change #1080407 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace use of deprecated ChangeTags::getTags(), defineTag(), and listExplicitlyDefinedTags()

https://gerrit.wikimedia.org/r/1080407

gerritbot added a comment.Oct 16 2024, 8:05 PM

Change #1080416 merged by jenkins-bot:

[mediawiki/core@master] Replace uses of deprecated ChangeTags static methods

https://gerrit.wikimedia.org/r/1080416

gerritbot added a comment.Oct 17 2024, 9:49 AM

Change #1080398 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Replace use of deprecated ChangeTags::addTags(), getTags(), ::getTagsWithData(), and ::updateTags()

https://gerrit.wikimedia.org/r/1080398

gerritbot added a comment.Oct 17 2024, 3:38 PM

Change #1081194 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] Follow-up Ide1ec27a5adbf2ccdebcacacea120a401657eee1

https://gerrit.wikimedia.org/r/1081194

SBisson updated the task description. (Show Details)Oct 17 2024, 3:38 PM
gerritbot added a comment.Oct 22 2024, 8:56 AM

Change #1081194 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Inject ChangeTagsStore into Api(Content|Section)TranslationPublish

https://gerrit.wikimedia.org/r/1081194

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Oct 22 2024, 9:00 AM
Jdforrester-WMF updated the task description. (Show Details)Mon, Oct 28, 12:34 PM
gerritbot added a comment.Mon, Nov 4, 4:41 PM

Change #1080417 merged by jenkins-bot:

[mediawiki/core@master] ChangeTags: Hard-deprecate methods deprecated in 1.41

https://gerrit.wikimedia.org/r/1080417

Jdforrester-WMF removed a project: MW-1.43-release.Mon, Nov 4, 4:49 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.2; 2024-11-05); removed MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Mon, Nov 4, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mon, Nov 4, 5:30 PM
Jdforrester-WMF updated the task description. (Show Details)Thu, Nov 7, 2:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits