⚓ T358827 Adjacent Field components should have spacing between them
Page MenuHomePhabricator

Adjacent Field components should have spacing between them
Closed, ResolvedPublic2 Estimated Story Points

Description

Right now, if you put two Field components right below each other (as is common in a form), they bump right up against each other with no spacing between them. This happens both if is-fieldset is true and if it's false:

image.png (599×659 px, 60 KB)

This doesn't look good. I would expect Fields to have some amount of spacing between them.

This should be updated to reflect the form guidelines from T330481 once that task is done.

Acceptance Criteria

  • Update the Field Component styles (both CSS and Vue versions) so that spacing between fields reflects the new Form Layout Guidelines (see T330481)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 1007750 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] [Proof of concept] Field: Demonstrate adjacent Fields

https://gerrit.wikimedia.org/r/1007750

lwatson subscribed.
lwatson changed the task status from Open to In Progress.Mar 8 2024, 6:29 PM
lwatson claimed this task.

Change 1010191 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] styles: spacing between adjacent field components

https://gerrit.wikimedia.org/r/1010191

Change 1007750 abandoned by VolkerE:

[design/codex@main] [Proof of concept] Field: Demonstrate adjacent Fields

Reason:

With Ib901fc3f7099019ea53924af3901002db72e4568 merged this POC isn't needed anymore.

https://gerrit.wikimedia.org/r/1007750

Change 1010191 merged by jenkins-bot:

[design/codex@main] styles: spacing between adjacent Field components

https://gerrit.wikimedia.org/r/1010191

Change 1012737 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from 1.3.4 to 1.3.5

https://gerrit.wikimedia.org/r/1012737

Change 1012737 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from 1.3.4 to 1.3.5

https://gerrit.wikimedia.org/r/1012737