⚓ T358325 Unsuppress Phan issues MediaWikiNoBaseException and MediaWikiNoEmptyIfDefined in Wikibase
Page MenuHomePhabricator
Create Task
Maniphest T358325

Unsuppress Phan issues MediaWikiNoBaseException and MediaWikiNoEmptyIfDefined in Wikibase
Closed, ResolvedPublic
Actions

Description

In build: Updating mediawiki/mediawiki-phan-config to 0.14.0, two Phan issue types were temporarily suppressed. We should actually fix our code according to the coding conventions (linked below) and remove these suppressions.

  • MediaWikiNoBaseException: Don’t throw \Exception; see exception handling.
  • MediaWikiNoEmptyIfDefined: Don’t use empty() on variables that are always set; see empty().

Details

SubjectRepoBranchLines +/-
Use RuntimeException/LogicException instead of Exceptionmediawiki/extensions/Wikibasemaster+34 -57
Replace empty() with strict compares to '', 0 or nullmediawiki/extensions/Wikibasemaster+7 -8
repo: Replace empty() with truthy/falsy checksmediawiki/extensions/Wikibasemaster+55 -56
lib/view: Replace empty() with truthy/falsy checksmediawiki/extensions/Wikibasemaster+19 -19
client: Replace empty() with truthy/falsy checksmediawiki/extensions/Wikibasemaster+36 -37
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 23 2024, 10:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2024, 10:47 AM
gerritbot added a comment.Mar 1 2024, 10:13 PM

Change 1007981 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] client: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1007981

gerritbot added a project: Patch-For-Review.Mar 1 2024, 10:13 PM
gerritbot added a comment.Mar 4 2024, 11:09 AM

Change 1007981 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1007981

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2024, 11:30 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 4 2024, 2:01 PM
gerritbot added a comment.Mar 4 2024, 7:46 PM

Change 1008527 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] lib/view: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1008527

gerritbot added a project: Patch-For-Review.Mar 4 2024, 7:46 PM
gerritbot added a comment.Mar 5 2024, 1:49 PM

Change 1008527 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] lib/view: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1008527

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2024, 2:31 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.22; 2024-03-12); removed MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 5 2024, 6:01 PM
gerritbot added a comment.Mar 5 2024, 8:48 PM

Change 1008949 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] repo: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1008949

gerritbot added a project: Patch-For-Review.Mar 5 2024, 8:48 PM
gerritbot added a comment.Mar 6 2024, 12:10 PM

Change 1008949 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1008949

Maintenance_bot removed a project: Patch-For-Review.Mar 6 2024, 12:31 PM
gerritbot added a comment.Mar 6 2024, 7:12 PM

Change 1009318 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Replace empty() with strict compares to '', 0 or null

https://gerrit.wikimedia.org/r/1009318

gerritbot added a project: Patch-For-Review.Mar 6 2024, 7:12 PM
Jdforrester-WMF updated the task description. (Show Details)Mar 8 2024, 1:55 PM
gerritbot added a comment.Mar 8 2024, 2:22 PM

Change 1009318 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace empty() with strict compares to '', 0 or null

https://gerrit.wikimedia.org/r/1009318

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2024, 2:30 PM
gerritbot added a comment.Mar 8 2024, 8:24 PM

Change 1009797 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Use RuntimeException/LogicException instead of Exception

https://gerrit.wikimedia.org/r/1009797

gerritbot added a project: Patch-For-Review.Mar 8 2024, 8:24 PM
gerritbot added a comment.Mar 11 2024, 5:11 AM

Change 1009797 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use RuntimeException/LogicException instead of Exception

https://gerrit.wikimedia.org/r/1009797

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2024, 5:30 AM
Umherirrender closed this task as Resolved.Mar 11 2024, 7:23 PM
Umherirrender claimed this task.
Umherirrender updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits