⚓ T357633 Replace usage of wfGetDB() in AntiSpoof before the 1.42 cut so it can be hard-deprecated
Page MenuHomePhabricator
Create Task
Maniphest T357633

Replace usage of wfGetDB() in AntiSpoof before the 1.42 cut so it can be hard-deprecated
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Replace wfGetDB() with ICP getReplicaDatabase()mediawiki/extensions/AntiSpoofmaster+5 -2
Replace wfGetDB() with ICP getReplicaDatabase()mediawiki/extensions/AntiSpoofmaster+8 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Feb 15 2024, 1:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2024, 1:48 PM
gerritbot added a comment.Feb 15 2024, 4:02 PM

Change 1003460 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/AntiSpoof@master] Replace wfGetDB() with ICP getReplicaDatabase()

https://gerrit.wikimedia.org/r/1003460

gerritbot added a project: Patch-For-Review.Feb 15 2024, 4:02 PM
gerritbot added a comment.Feb 19 2024, 12:21 PM

Change 1003460 merged by jenkins-bot:

[mediawiki/extensions/AntiSpoof@master] Replace wfGetDB() with ICP getReplicaDatabase()

https://gerrit.wikimedia.org/r/1003460

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2024, 12:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 19 2024, 2:00 PM
Jdforrester-WMF closed this task as Resolved.Feb 20 2024, 3:35 PM
Jdforrester-WMF claimed this task.
Reedy reopened this task as Open.Feb 20 2024, 3:37 PM
Reedy mentioned this in T357995: `Database error` error page when creating account on the beta cluster.
Reedy subscribed.

Patch reverted due to T357995: `Database error` error page when creating account on the beta cluster, because the MediaWiki-extensions-CentralAuth wasn't updated too

gerritbot added a comment.Feb 20 2024, 9:36 PM

Change 1005168 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AntiSpoof@master] Replace wfGetDB() with ICP getReplicaDatabase()

https://gerrit.wikimedia.org/r/1005168

gerritbot added a project: Patch-For-Review.Feb 20 2024, 9:36 PM
gerritbot added a comment.Feb 20 2024, 11:37 PM

Change 1005168 merged by jenkins-bot:

[mediawiki/extensions/AntiSpoof@master] Replace wfGetDB() with ICP getReplicaDatabase()

https://gerrit.wikimedia.org/r/1005168

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2024, 12:30 AM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.20; 2024-02-27); removed MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 22 2024, 11:02 AM
matmarex closed this task as Resolved.Mar 6 2024, 5:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits