When an IP is globally blocked and tries to perform an action, a error message is shown to the caller. The specific message is customisable via specific hooks and which hook is called depends on the type of target for the block. For example, GlobalBlockingBlockedIpMsg hook is run when the target is an IP address and GlobalBlockingBlockedIpRangeMsg is run when the target is an IP address range.
However, the only usage of any of these hooks (based on a codesearch search) is to provide Wikimedia specific message overrides in the WikimediaMessages extension. This can instead be done by specifying the message keys in Hooks::onMessageCacheFetchOverrides of the WikimediaMessages extension.
As such these hooks can be deprecated and also prevents the need to add a new hook for global blocks on accounts.
Acceptance criteria
- Deprecate GlobalBlockingBlockedIp, GlobalBlockingBlockedIpRange, and GlobalBlockingBlockedIpXff hooks
- Update the existing usages of these hooks in WikimediaMessages to use the Hooks::onMessageCacheFetchOverrides method and therefore remove the GlobalBlocking hook handler methods.