⚓ T298131 [WikiLambda] Add more and stronger tests for ZFunctionCall

Maniphest T298131

[WikiLambda] Add more and stronger tests for ZFunctionCall
Closed, ResolvedPublic
Actions

Description

Code coverage reports are automatically published for this codebase: https://doc.wikimedia.org/cover-extensions/WikiLambda/includes/ZObjects/ZFunctionCall.php.html

Details

	Subject	Repo	Branch	Lines +/-
	Test function call with fully specified value for Z7K1	mediawiki/extensions/WikiLambda	master	+514 -0
	Test a function call taking 2 arguments	mediawiki/extensions/WikiLambda	master	+18 -0
	Cover getZValue and getReturnType in ZFunctionCall tests	mediawiki/extensions/WikiLambda	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned In: T301718: Add more complex tests for ZFunctionCall
Mentioned Here: T300503: WikiLambda: For ZFunctionCall::getReturnType, get return type from DB instead of hardcoded Z4

Event Timeline

gengh created this task.Dec 21 2021, 7:42 PM

DVrandecic moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.Jan 11 2022, 5:15 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.

Jdforrester-WMF added a project: Technical-Debt.Jan 11 2022, 5:15 PM

DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Jan 11 2022, 5:46 PM

gengh added a project: Abstract Wikipedia Fix-It tasks.Jan 20 2022, 12:19 PM

Jdforrester-WMF updated the task description. (Show Details)Jan 31 2022, 8:27 PM

DMartin-WMF claimed this task.Jan 31 2022, 9:13 PM

A wider range of tests for getReturnType() can be added after T300503 is completed.

Change 759591 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Cover getZValue and getReturnType in ZFunctionCall tests

https://gerrit.wikimedia.org/r/759591

gerritbot added a project: Patch-For-Review.Feb 3 2022, 8:54 PM

Change 759591 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Cover getZValue and getReturnType in ZFunctionCall tests

https://gerrit.wikimedia.org/r/759591

Maintenance_bot removed a project: Patch-For-Review.Feb 4 2022, 10:10 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 4 2022, 11:00 AM

Change 760270 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Test a function call taking 2 arguments

https://gerrit.wikimedia.org/r/760270

gerritbot added a project: Patch-For-Review.Feb 6 2022, 10:00 PM

Change 760303 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Test function call with fully specified value for Z7K1

https://gerrit.wikimedia.org/r/760303

Change 760270 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Test a function call taking 2 arguments

https://gerrit.wikimedia.org/r/760270

Jdforrester-WMF moved this task from Ready to do to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Feb 8 2022, 7:03 PM

DMartin-WMF mentioned this in T301718: Add more complex tests for ZFunctionCall.Feb 14 2022, 7:23 PM

ZFunctionCall has 100% coverage, so moving this to ready to close.

Jdforrester-WMF closed this task as Resolved.Feb 16 2022, 6:00 PM