⚓ T292305 SX Compare contents: Fix overlap of content images and content header
Page MenuHomePhabricator
Create Task
Maniphest T292305

SX Compare contents: Fix overlap of content images and content header
Closed, ResolvedPublic
Actions

Description

When scrolling section contents or target page contents inside "Compare contents" step, images cover the content header. This creates an ugly visual effect and a confusing user experience.

image.png (818×378 px, 108 KB)

Details

SubjectRepoBranchLines +/-
SXContentComparatorContentHeader: Set z-index to fix stack ordermediawiki/extensions/ContentTranslationmaster+1 -0
Customize query in gerrit

Event Timeline

ngkountas created this task.Oct 1 2021, 5:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2021, 5:25 PM
ngkountas added a comment.Oct 1 2021, 5:37 PM

Screenshot after fix:

image.png (818×383 px, 119 KB)

gerritbot added a comment.Oct 1 2021, 5:44 PM

Change 725349 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXContentComparatorContentHeader: Set z-index to fix stack order

https://gerrit.wikimedia.org/r/725349

gerritbot added a project: Patch-For-Review.Oct 1 2021, 5:44 PM
ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2021-October-December) board.Oct 1 2021, 5:44 PM
gerritbot added a comment.Oct 4 2021, 5:40 AM

Change 725349 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXContentComparatorContentHeader: Set z-index to fix stack order

https://gerrit.wikimedia.org/r/725349

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 4 2021, 6:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 4 2021, 6:10 AM
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2021-October-December) board.Oct 19 2021, 8:18 PM
Pginer-WMF closed this task as Resolved.Oct 29 2021, 10:49 AM
Pginer-WMF moved this task from Needs QA to Done on the Language-Team (Language-2021-October-December) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits