Allow users to specify the URL template to use for fetching articles by d00rman · Pull Request #9 · wikimedia/htmldumper · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to specify the URL template to use for fetching articles #9

Merged
merged 2 commits into from
Apr 18, 2017
Merged

Allow users to specify the URL template to use for fetching articles #9

merged 2 commits into from
Apr 18, 2017

Conversation

d00rman
Copy link
Contributor

@d00rman d00rman commented Apr 15, 2017

Users might need to be able to specify a different URI scheme (use a different format, dump something other than HTML like summary, etc.), so allow them to do that.

Note: ideally we should be able to allow users full freedom and specify the complete request template.

@d00rman
Copy link
Contributor Author

d00rman commented Apr 15, 2017

cc @wikimedia/services @apergos @legoktm

@d00rman d00rman mentioned this pull request Apr 18, 2017
Open
@Pchelolo
Copy link
Contributor

LGTM

@Pchelolo Pchelolo merged commit 3ac4a24 into wikimedia:master Apr 18, 2017
@d00rman d00rman deleted the url-template branch April 18, 2017 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d00rman @Pchelolo