Is toc test s4.8.1.3.02 correct? · Issue #7 · w3c/publ-tests · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is toc test s4.8.1.3.02 correct? #7

Closed
iherman opened this issue Dec 18, 2019 · 5 comments
Closed

Is toc test s4.8.1.3.02 correct? #7

iherman opened this issue Dec 18, 2019 · 5 comments
Assignees
@mattgarrish

Comments

@iherman
Copy link
Member

iherman commented Dec 18, 2019

The setup is (for audiobooks) to locate the TOC in the PEP, because the manifest itself does not have a 'content' structure. This is all right (although see w3c/audiobooks#63 for issues around that).

The ToC in the PEP is:

<nav role="doc-toc">
	<h2>Test Table of Contents</h2>
	<ol>
		<li>
			<a href="#s1">Section 1</a>
		</li>
	</ol>
</nav>

meaning that the link in the ToC goes to .../tests/s4813-02/toc.html#s1. However, this URL does not appear in any resource list of the manifest; according to rule 4.6.2.2. this is an erroneous entry in the TOC.
@iherman iherman changed the title Is toc test s.4.8.1.3.02 correct? Is toc test s4.8.1.3.02 correct? Dec 18, 2019
@iherman
Copy link
Member Author

iherman commented Dec 18, 2019 •
edited
Loading

Actually, I believe the test is correct, but the Audiobook is missing a step to ensure that the PEP is properly taken into account when processing the manifest.

The answer is to extend the audiobook processing by adding a rule in the first item whereby the PEP must be added to unique resources (if not already there). This makes very much sense in general...

@iherman
Copy link
Member Author

iherman commented Dec 18, 2019

Beyond #7 (comment), actually (and in the general manifest case, not only for audiobooks) it may also make sense to add the HTML file that includes the TOC to the list of unique resources.

This file and the PEP might coincide (and it does in this test), but not necessarily. Both make sense for unique resources...

@iherman
Copy link
Member Author

iherman commented Dec 19, 2019

Oops, forget my last remark. The file including the toc is of course there already by virtue of the relevant entry in the resource list for toc.

@iherman iherman mentioned this issue Dec 19, 2019
Merged
@iherman
Copy link
Member Author

iherman commented Dec 19, 2019

See w3c/audiobooks#66 proposing the necessary changes

@iherman
Copy link
Member Author

iherman commented Mar 23, 2020

Closing... the changes have been implemented.

@iherman iherman closed this as completed Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattgarrish mattgarrish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iherman @mattgarrish