Safari iframe resize bug · Issue #14 · twbs/rfs · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari iframe resize bug #14

Closed
6 tasks done
MartijnCuppens opened this issue Jul 14, 2018 · 2 comments
Closed
6 tasks done

Safari iframe resize bug #14

MartijnCuppens opened this issue Jul 14, 2018 · 2 comments
Labels
bug less This issue only applies to the less version PostCSS sass This issue only applies to the sass version stylus This issue only applies to the stylus version

Comments

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Jul 14, 2018 •
edited
Loading

The font sizes do not rescale in iframes in safari when the iframe is rescaled. It's possible to avoid this by adding min-width: 0vw; in the media queries of RFS.
This is not the most ideal solution, and should be disabled by default.

Demo: https://codepen.io/MartijnCuppens/pen/djYBGW

  • Fix bug in scss
  • Fix bug in sass
  • Fix bug in PostCSS
  • Fix bug in Stylus
  • Fix bug in less
  • Update readme

In this demo another codepen is secretly loaded which adds some dirty code to fix this: https://codepen.io/MartijnCuppens/pen/ZBjdMy?editors=1100
@MartijnCuppens MartijnCuppens added bug less This issue only applies to the less version scss sass This issue only applies to the sass version stylus This issue only applies to the stylus version PostCSS labels Jul 14, 2018
MartijnCuppens added a commit that referenced this issue Jul 16, 2018
@MartijnCuppens
#14: safari iframe resize bug fix
5a26f52
MartijnCuppens added a commit that referenced this issue Jul 16, 2018
@MartijnCuppens
#14: safari iframe resize bug fix stylus
a87301b
MartijnCuppens added a commit that referenced this issue Jul 17, 2018
@MartijnCuppens
#14: safari iframe fix - less
c1e997e
MartijnCuppens added a commit that referenced this issue Jul 17, 2018
@MartijnCuppens
#14: safari iframe fix - sass fix
c917e32
MartijnCuppens added a commit that referenced this issue Jul 17, 2018
@MartijnCuppens
#14: safari iframe fix - PostCSS
2352863
MartijnCuppens added a commit that referenced this issue Jul 17, 2018
@MartijnCuppens
#14: safari iframe fix - documentation update
27c5ef7
MartijnCuppens added a commit that referenced this issue Jul 17, 2018
@MartijnCuppens
#14: safari iframe fix - documentation update fix
5704654
MartijnCuppens added a commit that referenced this issue Jul 17, 2018
@MartijnCuppens
#14: safari iframe fix - documentation update fix
91e421e
MartijnCuppens added a commit that referenced this issue Jul 17, 2018
@MartijnCuppens
#14: Safari iframe bug fix implementation
e817180
@MartijnCuppens
Copy link
Member Author

Fixed in v7.1.3

@MartijnCuppens MartijnCuppens mentioned this issue Mar 4, 2019
Open
4 tasks
MartijnCuppens added a commit that referenced this issue Mar 20, 2019
@MartijnCuppens
#14: safari iframe resize bug fix
8097cd2
MartijnCuppens added a commit that referenced this issue Mar 20, 2019
@MartijnCuppens
#14: safari iframe resize bug fix stylus
8191235
MartijnCuppens added a commit that referenced this issue Mar 20, 2019
@MartijnCuppens
#14: safari iframe fix - less
8cfd922
MartijnCuppens added a commit that referenced this issue Mar 20, 2019
@MartijnCuppens
#14: safari iframe fix - sass fix
961da10
MartijnCuppens added a commit that referenced this issue Mar 20, 2019
@MartijnCuppens
#14: safari iframe fix - PostCSS
cf032a0
MartijnCuppens added a commit that referenced this issue Mar 20, 2019
@MartijnCuppens
#14: safari iframe fix - documentation update
bc205a7
MartijnCuppens added a commit that referenced this issue Mar 20, 2019
@MartijnCuppens
#14: safari iframe fix - documentation update fix
5925889
MartijnCuppens added a commit that referenced this issue Mar 20, 2019
@MartijnCuppens
#14: safari iframe fix - documentation update fix
6cccf56
MartijnCuppens added a commit that referenced this issue Mar 20, 2019
@MartijnCuppens
#14: Safari iframe bug fix implementation
fa5cabd
@mblackritter
Copy link

I wonder if this might be set as a default for the demos, because it could be rather surprising to initially see it in a non working state. 😍🥰

At least It buzzled me, beside that I knew it generally works, because I already implemented it.

@archiloque archiloque mentioned this issue Jun 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug less This issue only applies to the less version PostCSS sass This issue only applies to the sass version stylus This issue only applies to the stylus version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mblackritter @MartijnCuppens and others