Integrate fmt and vet checks into golangci-lint by tksm · Pull Request #260 · stern/stern · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate fmt and vet checks into golangci-lint #260

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Integrate fmt and vet checks into golangci-lint #260

merged 2 commits into from
Apr 14, 2023

Conversation

tksm
Copy link
Contributor

@tksm tksm commented Apr 14, 2023

This PR integrates fmt and vet checks in Makefile into golangci-lint. It configures golangci-lint to enable gofmt and the default linters, including govet.

superbrothers
superbrothers approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@superbrothers superbrothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@superbrothers superbrothers merged commit 1d242bc into stern:master Apr 14, 2023
@tksm tksm deleted the golangci-lint-config branch April 14, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superbrothers superbrothers superbrothers approved these changes

@floryut floryut Awaiting requested review from floryut floryut is a code owner

@rkmathi rkmathi Awaiting requested review from rkmathi rkmathi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tksm @superbrothers