Fixes to deprecation warnings starting in PHP 8.2 #248
Conversation
Using `${var}` to embed variables in strings causes warnings starting
in PHP 8.2. This commit replaces two instances with `{$var}`, following
recommendations in the deprecation notice and related RFC.
Calling `reset()` on an object causes warnings starting in PHP 8.2. This commit replaces one instance with ArrayIterator object and getIterator() method following a recommendation in the deprecation notice RFC.
neapsix
changed the title
There was a problem hiding this comment.
Looks good to me! I didn't know the ${var} syntax had been deprecated. It's been kinda my default go-to, since that's what you do in Bash.
Thanks for the update! Do you have a link to that deprecation notice at all? Probably worth me giving it a read.
I assume this doesn't kill support for e.g. 8.1?
|
Hey, thanks so much for the merges! Here are the links to the RFC and migration notes for
I agree that the And for calling
These changes shouldn't break support for PHP 8.0 and 8.1! I just re-tested 8.1 and verified that internal links and searching work as expected. I don't have a VM with 8.0 handy, but I recall that I checked it before and didn't see any issues. |
Hello! Another patch for you to consider. This PR updates a few lines that still work but cause deprecation warnings starting in PHP 8.2.
The first commit replaces
${var}with{$var}. The second uses an iterator instead of callingreset()on an object. I've validated them on FreeBSD with Apache and PHP 8.0, 8.1, and 8.2.I followed the guidance in the deprecation notices but don't have much experience with PHP—happy to change or rework based on your feedback. Thank you so much!
I agree to release this contribution under the Mozilla Public License 2.0.