Add new Lint/ConstantOverwrittenInRescue cop
#10722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
force-pushed
the
add_overwrite_by_rescue
branch
from
19a85ec
to
0401f94
Compare
|
Wow! > E=Class.new(StandardError)
> begin; raise E; rescue => E; end
(pry):2: warning: already initialized constant E
(pry):1: warning: previous definition of E was here
> E
#<E: E>😱 Frankly, it looks like a Ruby bug or a deficiency. In any case, thanks for the cop! 👏 |
bbatsov
reviewed
Jun 19, 2022
|
I like the cop, we just need to expand a bit the docs and the examples. |
bbatsov
reviewed
Jun 19, 2022
bbatsov
reviewed
Jun 19, 2022
|
I'd go with |
This PR is add a new cop. Checks for overwriting an exception with an exception result by use `rescue =>`. You intended to write as `rescue StandardError`. However, you have written `rescue => StandardError`. In that case, the result of `rescue` will overwrite `StandardError`. ## @example ```ruby # bad begin something rescue => StandardError end # good begin something rescue StandardError end ```
ydah
force-pushed
the
add_overwrite_by_rescue
branch
from
0401f94
to
a24174a
Compare
|
@pirj Thank you so much. |
ydah
changed the title
Lint/OverwriteByRescue copLint/ConstantOverwrittenInRescue cop
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is add a new cop.
Checks for overwriting an exception with an exception result by use
rescue =>.@example
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.