Simplify Session.sweep method example in security doc [ci skip]
#42116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
deleted the
Simplify__Session_sweep__method_example_in_security_doc__ci_skip_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies
Session.sweepmethod implementation example in the security guide.I removed the String to Time conversion of
Session.sweepmethod.I think removing the conversion introduces two benefits.
First, the method will focus on the main feature, which is expiring old sessions, by this change.
The conversion is not required to understand how to expire sessions. And the implementation is a bit difficult. So it will be easy to understand by removing it, but it still describes the main feature.
Second, the conversion introduces security issues.
It uses
Kernel.#sendmethod, so any methods of Integer are callable via the argument. For example,Session.sweep('42 sleep')sleeps forever.Actually, it doesn't become a problem rarely. But I think the potential problem is not appropriate for the "security" document.