Added HTTP Basic access authentication via --auth-user and --auth-password by sgjava · Pull Request #122 · matomo-org/matomo-log-analytics · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added HTTP Basic access authentication via --auth-user and --auth-password #122

Merged
merged 1 commit into from
Jan 26, 2016
Merged

Added HTTP Basic access authentication via --auth-user and --auth-password #122

merged 1 commit into from
Jan 26, 2016

Conversation

sgjava
Copy link
Contributor

@sgjava sgjava commented Jan 26, 2016

Added ability to use Basic access authentication.

@tsteur
Copy link
Member

tsteur commented Jan 26, 2016

Looks good to me and thx for the detailed docs

tsteur added a commit that referenced this pull request Jan 26, 2016
@tsteur
Merge pull request #122 from sgjava/master
dd28985 
Added basic auth
@tsteur tsteur merged commit dd28985 into matomo-org:master Jan 26, 2016
@tsteur tsteur added this to the Current sprint milestone Jan 26, 2016
@mattab mattab changed the title Added basic auth Added HTTP Basic access authentication via --auth-user and --auth-password Jan 26, 2016
@mattab
Copy link
Member

mattab commented Jan 27, 2016

This broke the build

2) Piwik\Tests\System\ArchiveCronTest

Failed to setup fixture: log importer failed: 2016-01-27 03:48:18,040: [DEBUG] Accepted hostnames: all

2016-01-27 03:48:18,040: [DEBUG] Piwik URL is: http://localhost/tests/PHPUnit/proxy/

2016-01-27 03:48:18,040: [DEBUG] No token-auth specified

2016-01-27 03:48:18,040: [DEBUG] Using credentials: (login = superUserLogin, password = 1e56c228742c0189d261500852e27a02)

Traceback (most recent call last):

  File "/home/travis/build/piwik/piwik/misc/log-analytics/import_logs.py", line 2305, in <module>

    config = Configuration()

  File "/home/travis/build/piwik/piwik/misc/log-analytics/import_logs.py", line 864, in __init__

    self._parse_args(self._create_parser())

  File "/home/travis/build/piwik/piwik/misc/log-analytics/import_logs.py", line 844, in _parse_args

    self.options.piwik_token_auth = self._get_token_auth()

  File "/home/travis/build/piwik/piwik/misc/log-analytics/import_logs.py", line 883, in _get_token_auth

    _url=self.options.piwik_url,

  File "/home/travis/build/piwik/piwik/misc/log-analytics/import_logs.py", line 1335, in call_api

    return cls._call_wrapper(cls._call_api, None, None, method, **kwargs)

  File "/home/travis/build/piwik/piwik/misc/log-analytics/import_logs.py", line 1292, in _call_wrapper

    response = func(*args, **kwargs)

  File "/home/travis/build/piwik/piwik/misc/log-analytics/import_logs.py", line 1278, in _call_api

    res = Piwik._call('/', final_args, url=url)

  File "/home/travis/build/piwik/piwik/misc/log-analytics/import_logs.py", line 1235, in _call

    if config.options.auth_user is not None:

NameError: global name 'config' is not defined

see: https://travis-ci.org/piwik/piwik/jobs/105077418

mattab added a commit that referenced this pull request Jan 27, 2016
@mattab
Fixes error NameError: global name 'config' is not defined #122
aa98189
@mattab
Copy link
Member

mattab commented Jan 27, 2016

FYI: should be fixed in aa98189

mattab added a commit to matomo-org/matomo that referenced this pull request Jan 27, 2016
@mattab
Log Analytics basic http auth fix matomo-org/matomo-log-analytics#122
3cee9f4
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sgjava @tsteur @mattab @innocraft-automation