Allow up to 63 characters TLD in email address #9486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should allow for 63 characters TLDs, according to RFC 1035, instead of arbitrary 10. https://en.wikipedia.org/wiki/Domain_Name_System#cite_ref-rfc1034_1-2 As far as minimum length of 2 is acceptable, becuse IANA says that it isn't likely to introduce 1 character TLD, maximium length is too short. This partially resolves #9485
|
Cloud someone from Pwik team kick this job? https://travis-ci.org/piwik/piwik/jobs/101118866 for me? It have errored on something random |
|
Is there maybe a way we do not have to update Zend? Maybe we can configure a hostname class? |
|
@tsteur This PR resolves problem temporarily. |
|
OK Cheers, looks good to merge. Should we create a new issue to solve it permanently? |
tsteur
added a commit
that referenced
this pull request
Jan 12, 2016
#9485 Allow up to 63 characters TLD in email
|
Created #9509 |
mattab
changed the title
sebastianpiskorski
added a commit
to sebastianpiskorski/piwik
that referenced
this pull request
Mar 24, 2016
tsteur
added a commit
that referenced
this pull request
Mar 28, 2016
Test for PR #9486, Validate allowed TLDs with current IANA list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should allow for 63 characters TLDs, according to RFC 1035, instead of arbitrary 10.
https://en.wikipedia.org/wiki/Domain_Name_System#cite_ref-rfc1034_1-2
As far as minimum length of 2 is acceptable, becuse IANA says that it isn't likely to introduce 1 character TLD, maximium length is too short.
Also updated valid TLDs list to current state: http://data.iana.org/TLD/tlds-alpha-by-domain.txt
This partially resolves #9485