Fixes escaping in tag clouds #9447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Bug
| @@ -1,7 +1,7 @@ | |||
| {% set cloudColumn = properties.columns_to_display[1] %} | |||
| <div class="tagCloud"> | |||
| {% for word,value in cloudValues %} | |||
| <span title="{{ value.word }} ({{ value.value }} {{ properties.translations[cloudColumn]|default(cloudColumn) }})" class="word size{{ value.size }} | |||
| <span title="{{ value.word|rawSafeDecoded }} ({{ value.value }} {{ properties.translations[cloudColumn]|default(cloudColumn) }})" class="word size{{ value.size }} | |||
There was a problem hiding this comment.
Do we need to call $word = Common::unsanitizeInputValue($word); as well? So far it seems only wordTruncated is handled or was $word already working?
There was a problem hiding this comment.
I've added that for truncated word only, as otherwise the text might be cut off within a encoded char like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it can be seen in the UI tests, the words in tag clouds might get displayed escaped:
With this changes it looks correct: