Fixes jumping effect in dashboard on widget hover by sgiehl · Pull Request #9414 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes jumping effect in dashboard on widget hover #9414

Merged
merged 1 commit into from
Dec 20, 2015
Merged

Fixes jumping effect in dashboard on widget hover #9414

merged 1 commit into from
Dec 20, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 19, 2015

Fixes #9022.

To prevent the jumping effect I decided to choose a more complicate way.

The simplest way would have been to always force the line break getting visible when hovering, but imho it looked a bit ugly always having the free space in the right-top corner.

With this changes a background gradient is used, to hide some parts of the title, if it is too close to the buttons.

This is how it looks like by default and when hovering the widget:

image

... and when hovering the title:

image

@sgiehl sgiehl added Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 19, 2015
@tsteur tsteur added this to the 2.15.1 milestone Dec 20, 2015
@tsteur
Copy link
Member

tsteur commented Dec 20, 2015

Should we test in browsers like IE9? Let me know if so :) Really nice solution 👍

tsteur added a commit that referenced this pull request Dec 20, 2015
Fixes jumping effect in dashboard on widget hover
@tsteur tsteur merged commit 26a733f into master Dec 20, 2015
@tsteur tsteur deleted the 9022 branch December 20, 2015 19:20
mattab added a commit that referenced this pull request Dec 20, 2015
@mattab mattab removed the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants