Make sure local time has valid time format by mattab · Pull Request #9280 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure local time has valid time format #9280

Merged
merged 1 commit into from
Nov 27, 2015
Merged

Make sure local time has valid time format #9280

merged 1 commit into from
Nov 27, 2015

Conversation

mattab
Copy link
Member

@mattab mattab commented Nov 26, 2015

fixes #9052

@mattab mattab added the Needs Review PRs that need a code review label Nov 26, 2015
@mattab mattab added this to the 2.15.1 milestone Nov 26, 2015
@tsteur
Copy link
Member

tsteur commented Nov 26, 2015

LGTM . In general I'm wondering if we should rather throw an exception and make user aware that wrong values are sent and that "wrong" values will be tracked similar to maybe #7202 (comment) ?

@mattab
Copy link
Member Author

mattab commented Nov 27, 2015

@tsteur we don't throw exception in tracker AFAIK so I wouldn't start now (although it may be a good idea...). If we threw exception I think we would also need #7550

@tsteur
Copy link
Member

tsteur commented Nov 27, 2015

Yeah we don't do it yet but we should start at some point, possibly when working on #7550 . That's what we discussed last time I think. LGTM anyway :)

tsteur added a commit that referenced this pull request Nov 27, 2015
@tsteur
Merge pull request #9280 from piwik/9052
d54ddc8 
Make sure local time has valid time format
@tsteur tsteur merged commit d54ddc8 into master Nov 27, 2015
@tsteur tsteur deleted the 9052 branch November 27, 2015 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mattab @tsteur