Re-add backwards compatibility for URLs using old UserSettings plugin. #8941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
c: Platform
| @@ -78,7 +78,7 @@ | |||
| * @return bool | |||
| */ | |||
| function Piwik_ShouldPrintBackTraceWithMessage() | |||
| { | |||
| {return true; | |||
diosmosis
force-pushed
the
8923_usersettings_bc
branch
from
79d4900 to
643b7e6
Compare
| @@ -49,4 +50,33 @@ public function extendVisitorDetails(&$visitor, $details) | |||
| $visitor['browserVersion'] = $instance->getBrowserVersion(); | |||
| } | |||
|
|
|||
| public function renameUserSettingsModuleAndAction(&$module, &$action) | |||
There was a problem hiding this comment.
Can we remove it again in Piwik 3.0 maybe? We could add a reminder to remove it in DeprecatedMethodsTest
There was a problem hiding this comment.
Added to DeprecatedMethodsTest.
diosmosis
force-pushed
the
8923_usersettings_bc
branch
from
d017ad8 to
643b7e6
Compare
added 3 commits
October 8, 2015 09:54
… + add test coverage so BC break will be detected in the future.
…ins) & split up the tests for that BC.
…dMethodsTest so they will be removed in 3.0.
diosmosis
force-pushed
the
8923_usersettings_bc
branch
from
b821019 to
83f1368
Compare
|
Ready for another review/merge. |
mattab
pushed a commit
that referenced
this pull request
Oct 8, 2015
Re-add backwards compatibility for URLs using old UserSettings plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Includes system tests so BC break will be detected in the future. And includes tweaks to UI tests for more coverage.
Fixes #8923