fix various issues with user menu. by tsteur · Pull Request #7334 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix various issues with user menu. #7334

Merged
merged 1 commit into from
Mar 3, 2015
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 3, 2015

  • When clicking on the anonymous user a login form was shown
  • Some menu items were shown although the anonymous user has no access to it

We will now load the Help page when clicking on anonymous user name.
If the plugin Feedback is not activated we will open the API page since
this has to be activated. If Feedback plugin is disabled the anonymus user login
which will be a known issue but I think we can ignore this case.

* When clicking on the anonymous user a login form was shown
* Some menu items were shown although the anonymous user has no access to it

We will now load the Help page when clicking on anonymous user name.
If the plugin Feedback is not activated we will open the API page since
this has to be activated. If Feedback plugin is disabled the anonymus user login
which will be a known issue but I think we can ignore this case.
@tsteur tsteur added the Needs Review PRs that need a code review label Mar 3, 2015
@mattab mattab added this to the Piwik 2.11.2 milestone Mar 3, 2015
mattab pushed a commit that referenced this pull request Mar 3, 2015
fix various issues with user menu.
@mattab mattab merged commit ece78fa into master Mar 3, 2015
@mattab
Copy link
Member

mattab commented Mar 3, 2015

👍

@diosmosis diosmosis deleted the anonymous_user_menu_fix branch March 4, 2015 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants