More explicit messages for purging by ThaDafinser · Pull Request #7305 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More explicit messages for purging #7305

Merged
merged 2 commits into from
Mar 1, 2015
Merged

More explicit messages for purging #7305

merged 2 commits into from
Mar 1, 2015

Conversation

ThaDafinser
Copy link
Contributor

Instead of only Purging temporary archives: skipped the new patch shows either "no authorization" or "timeout".

Maybe the messages need to get adjusted

Also i changed a bit the way of the method to follow https://github.com/object-calisthenics/phpcs-calisthenics-rules
(should be easier)

@mnapoli
Copy link
Contributor

mnapoli commented Feb 26, 2015

👍 I like the cleaner code.

The only remark is that it shows skipped (6h wait timeout), if that time changes the message will not be up to date. Maybe use the $hoursBetweenPurge variable (and maybe change the message to skipped (purging every 6 hours))?

diosmosis added a commit that referenced this pull request Mar 1, 2015
More explicit messages for temporary/redundant archive purging.
@diosmosis diosmosis merged commit d556d33 into matomo-org:master Mar 1, 2015
@mnapoli mnapoli added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Mar 1, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants