Let Segments define a callback to use for suggested values in segment editor by czolnowski · Pull Request #6192 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Segments define a callback to use for suggested values in segment editor #6192

Merged
merged 1 commit into from
Sep 11, 2014
Merged

Let Segments define a callback to use for suggested values in segment editor #6192

merged 1 commit into from
Sep 11, 2014

Conversation

czolnowski
Copy link
Contributor

This code add possibility to overwrite suggested values with your own data from callback. (for example some custom query or static suggested data)

@czolnowski
Add setter for suggested values callback.
f93850a 
Use suggested values callback in getSuggestedValuesForSegment API method.
@mattab
Copy link
Member

mattab commented Sep 11, 2014

This looks like a small yet really useful and well done change.Cheers!

mattab pushed a commit that referenced this pull request Sep 11, 2014
Merge pull request #6192 from czolnowski/segment-suggested-values-cal…
8adb051 
…lback

Use callback instead of raw data for segment suggested values
@mattab mattab merged commit 8adb051 into matomo-org:master Sep 11, 2014
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Sep 11, 2014
@mattab mattab changed the title Use callback instead of raw data for segment suggested values Let Segments define a callback to use for suggested values in segment editor Sep 11, 2014
@czolnowski
Copy link
Contributor Author

The goal was: simple as possible, but fully functional. Thanks for quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czolnowski @mattab