-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User ID implementation #6169
Merged
Merged
User ID implementation #6169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new user_id field to contain the raw user id value - new &uid= tracker api parameter - add userId to Live API output - added integration test
…ndors to keep builds light
…is may fail the test with changes in Tracker.php
…ration tests + doc blocks
…ting user is anonymous
… and Last visits widget link/tooltip opening the Visitor profile
Conflicts: core/Version.php misc/package/build.sh
…s. Means "Active Users". Displayed in Visitors Overview, in metrics picker, in API response, in Metadata
… as this is not a valid operation.
…ports + fix some tests
…_* to also affect the nb_uniq_users metric processing over periods, + only show Users metrics when it's greater than zero, + fix more tests and renamed test suite to UserIdAndVisitorIdTest
and restore Transitions tests which I deleted by mistake earlier
…ome reason the column does appear by default but in the backwardsCompatibilityTest it does not appear there. Also had to manually activate and install plugins in the test case for some reason. Message was: ``` Exception: Failed to update database (errors or warnings found): Array ( [warnings] => Array ( ) [errors] => Array ( [0] => /home/matt/dev/piwik-master/plugins/CustomAlerts/Updates/0.0.2.php: Error trying to execute the query 'ALTER TABLE `alert` CHANGE `enable_mail` `email_me` BOOLEAN NOT NULL'. The error was: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'piwik_tests.alert' doesn't exist ) [coreError] => [deactivatedPlugins] => Array ( [0] => CustomAlerts ) ) ```
…tion #344 adding optout iframe screenshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests contains the implementation for User ID feature including Tracker API, JS and PHP Clients, new segment
userId
, displayed in Visitor Log and Visitor Profile, tests, and a newnb_users
metric displayed in most APIs outputs.Refs #6109 #3490 #6162