-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated searchEngine and social icons #11093
Conversation
Note: We do not need images for all urls in the definition files. There is only one needed for each search engine / social network. The file name needs to have the url first listed in the search engine / social definition (regardless from which url you are able to pull it). |
I forgot to comment, but I have removed the unnecessary images and sharpened them as mentioned in #11063 (comment). |
The large icons in the tables should be resolved with this change in the first pull request: |
Looks awesome @Findus23 - is the PR now ready to merge do you think? |
This PR is ready? Just noticed the icons have different sizes. But guess that is the maximum size you could grab for each, correct? |
Exactly, most people use 16x16px as a favicon, but some had higher resolution icons, which I used. |
* updated browser and os icons (#11063) * updated browser-icons from https://github.com/Findus23/device-icons 72d5ffef94a597c4ba226b33344e0badaadc3c35 * added os icons * added previous icons * changed macOS icon * replaced optipng with pngquant (36% size reduction) * center icons vertically * sharpen icons * increased icon size to 48x48 * fixed visitorPopup and realtimemap * revert css change * fixed HTML-Reports * replaced Windows icon #11063 (comment) * max-width and max-height for datatables * removed submodul (sorry wrong commit) * add explicit max-size for dataTableRowActions * fixed UNK.png * first try at fixing system tests * fixed cookie.gif * updates icons in System tests * updated plugin icons (#11121) * updated plugin icons * increased icon size to 48x48 * updated searchEngine and social icons (#11093) * updated and added searchEngine and social icons * removed unnecessary icons * sharpen icons * increased icon size to 48x48 * fixed promovideo socialicons http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/21859/UIIntegrationTest_dashboard1.png * fixed xx.png * updates plugin icons in system tests * [tests] RockMelt has it's own icon * updates expected UI test files * submodule update * fix some last tests
Follow-up to #11063: (related to #10587, #9292 and matomo-org/searchengine-and-social-list#28)
I have crawled all URLs from the searchengine-and-social-list and added
<link rel="shortcut icon" href="/absolute/or/relative/link" />
<link rel="icon" href="/absolute/or/relative/link" />
/favicon.ico
If the .ico contains multiple sizes, the largest is extracted.
Finally, all images are converted to png.
To preserve historical data, I haven't deleted images of sites that aren't online any more.
Work in progress as I haven't checked all of them. (GitHub unfortunately shows only 25 visual diffs)