when there's an error during Twig template processing, or during LESS css compiling, or a generic PHP error, display the safe mode by mattab · Pull Request #11083 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when there's an error during Twig template processing, or during LESS css compiling, or a generic PHP error, display the safe mode #11083

Merged
merged 2 commits into from
Dec 26, 2016
Merged

when there's an error during Twig template processing, or during LESS css compiling, or a generic PHP error, display the safe mode #11083

merged 2 commits into from
Dec 26, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Dec 26, 2016 •
edited
Loading

ref #11082

@mattab mattab added the Needs Review PRs that need a code review label Dec 26, 2016
@mattab mattab added this to the 3.0.1 milestone Dec 26, 2016
@mattab mattab mentioned this pull request Dec 26, 2016
Closed
@mattab mattab changed the base branch from 3.x-dev to safe_mode_plus December 26, 2016 02:41
@mattab
Copy link
Member Author

mattab commented Dec 26, 2016

I need to merge it already but feel free to review in #11082

@mattab mattab merged commit 4977645 into safe_mode_plus Dec 26, 2016
@mattab mattab deleted the safe_mode_when_twig_or_less_errors branch December 26, 2016 02:46
@mattab mattab changed the title when there's an error during Twig template processing, or during LESS css compiling, display the safe mode when there's an error during Twig template processing, or during LESS css compiling, or a generic PHP error, display the safe mode Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
1 participant
@mattab