The new icons look really great. Awesome!

As we wouldn't want to lose some icons, we should not remove any icon that was there before. Could you add back those low res icons as PNG? Then I think we can merge. Or did you want to do more work before we merge?

I now have added the previous icons (and changed the macOS-icon)

I'm currently working on newer Referrers-icons, but I'll probably create a new pull request.

What about the (obviously) failing tests?

What about the (obviously) failing tests?

Don't worry about the tests we'll fix them at the end or after merging

@Findus23 sounds good to create separate PR for referrers icons, will make it slightly easier for us too

Do you know if we could maybe find a s sharper icon for Firefox icon? i'm not too sure but it looks like a bit blurry in http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/21604/processed/UIIntegrationTest_visitors_software.png

sharper icon for Firefox icon

I am using https://github.com/Findus23/device-icons/blob/master/src/DevicesDetection/images/browsers/FF.png which is a png of the latest svg from Wikipedia Commons.

I think the effect is because I am using the new logo which is "flatter" than the older ones:

(from https://www.mozilla.org/en-US/styleguide/identity/firefox/branding/)

@Findus23 maybe the algorithm used in the image downsizing could participate in the blurriness as well. i've noticed in the past huge differences in quality depending on how the scaling down is done. Do you know if there are several algorithms available in your script (eg. bicubic / sinc / lanczos /etc. I think would be interesting to try a few different ones and pick the one that generates clearer icons for 16px size?

That's a good Idea.
As I am using ImageMagick there are hundreds of ways to change the algorithm so I'll need to do some testing.

@Findus23

Ok good to know. i'm sure with imagick we could get a great end result.

pngquant -f --ext .png -s 1 --skip-if-larger --quality 70-95 "$distFile"

do you know why this line is in the script? probably would be good to use a lossless algorithm 👍

probably would be good to use a lossless algorithm

At first I was using optipng -o 9 -q "$distFile" (which is lossless) but with https://github.com/Findus23/device-icons/commit/c1e46fd9dc210ad3c6608d90aa9a4f9cd47825f0 and
911f623 I changed it to pngquant as it produces even smaller files and I wasn't able to see a difference.

But I don't mind going back to optipng as a few KB more or less are not that important.

also can't see a difference on the first few icons that github shows the visual diff, likely the biggest factor is the imagick algorithm 👍

You were right. There is a way of avoiding blur when resizing: Unsharped Resizing (USM)
By adding the parameter -unsharp 0x1 the icons get much clearer.

before	after

Well done @Findus23 for finding this.... the difference looks amazing!

Please use the official Windows logo in its official blue color, not this ugly mismatch.

Also, Edge should get its own icon as well instead of the Internet Explorer icon.

@Studio384 feel free to submit the icon that should be used

@Findus23 do you think the PR is ready to be merged? (any minor changes could be done afterwards but good to merge early and get this in beta)

@Studio384, you are right. The windows logo I used isn't the "official" logo but a modification for Wikipedia (https://commons.m.wikimedia.org/wiki/File:Windows_logo_-_2012_derivative.svg). We should probably use the official one (even though it is harder to recognise in my opinion).
I'll change it tomorrow.
About edge: I'm not sure what you mean. I think I am using the right icon for edge (https://github.com/Findus23/device-icons/blob/master/src/DevicesDetection/images/browsers/PS.png). Do you mean another icon?

If you have other ideas for improvements just mention it.

@Findus23 I'm sorry, didn't see the Edge icon. Why is it called PS? I guess it's a left-over from Project Spartan?

Either way, I don't really see why the official Windows logo would be harder to recognize than an onofficial home-made version no-one will ever see. Either way, when you update it, make sure to use the 2015 version from Windows 10, with the Windows 10-blue color.

@Studio384 , so you mean https://commons.m.wikimedia.org/wiki/File:Windows_logo_–_2012_(dark_blue).svg?

@mattab there is just one thing I'd like to change before this (and the other pull requests) are ready for testing.
Because of the resize we need to explicitly add the size of 16x16px to every <img> in Piwik.
I have changed most of them (the ui test will show if I missed some), except for:

• the HTML report (which seems to be easy)
• the icons in datatables (so all tables in the software tab)
  For this I need your help as I haven't found a solution for defining the sizes for them. (More beautiful (and vectorised?) icons for browsers, operating systems, device types, device plugins #10587 (comment) and following)

@Studio384 I have now replaced the logo in https://github.com/Findus23/device-icons/commit/9ace925bc773bef8e8ccff9ed8e0bdf0b3009af5 and 34ee28d.

@Findus23 Yes, that's the version I ment.

I'm gonna merge that in a new branch now and fix the remaining tests before merging to 3.x-dev
Thanks for this awesome PR.

Could you also merge the other two pull requests in this branch as they would also need changes in the tests?

Good Point. I'll do that