When the page is loaded over HTTPS but Piwik thinks it is loaded over HTTP, explain in a notification how to solve issue · Issue #9145 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the page is loaded over HTTPS but Piwik thinks it is loaded over HTTP, explain in a notification how to solve issue #9145

Closed
mattab opened this issue Nov 2, 2015 · 1 comment
Closed

When the page is loaded over HTTPS but Piwik thinks it is loaded over HTTP, explain in a notification how to solve issue #9145

mattab opened this issue Nov 2, 2015 · 1 comment
Assignees
@tsteur
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone
2.16.0

Comments

@mattab
Copy link
Member

mattab commented Nov 2, 2015

from #6703 (comment)

  • Display a notification to user:

    • when in JavaScript in Piwik reporting UI, we can detect whether https is current protocol used,
    • and when Piwik server side thinks that http is used,
    • The notification explains to user something such as:

    You are currently viewing Piwik over secure SSL connection (using https), but Piwik could only detect that a non secure connection was used. To make sure Piwik correctly requests your content over HTTPS, you may edit your config.ini.php file and configure your proxy settings, or you may add below [General] the line: assume_secure_protocol=1. Learn more
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Nov 2, 2015
@mattab mattab mentioned this issue Nov 2, 2015
Closed
@mattab
Copy link
Member Author

mattab commented Nov 2, 2015

Note: assume_secure_protocol=1 is currently auto-detected during installation only and will be set in config when:

  • JavaScript detected https
  • and Piwik server did not detect https

Problem lies in the fact that user may change the Piwik setup after installation (ie. change the proxy setup, or SSL proxy), and this may break Piwik. Showing this notification will help users restore Piwik working securely over SSL.

@mattab mattab added this to the 2.15.1 milestone Nov 2, 2015
@mattab mattab mentioned this issue Nov 2, 2015
Closed
@tsteur tsteur self-assigned this Nov 16, 2015
tsteur added a commit that referenced this issue Nov 16, 2015
@tsteur
fixes #9145 show a warning when https was not detected correctly
3cd3cb4
@tsteur tsteur mentioned this issue Nov 16, 2015
Merged
@halfer halfer mentioned this issue Jun 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
2 participants
@tsteur @mattab