Regression tests fail with python-consul 1.5.1 · Issue #3189 · patroni/patroni · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression tests fail with python-consul 1.5.1 #3189

Closed
1 task done
mbanck opened this issue Oct 19, 2024 · 0 comments · Fixed by #3191
Closed
1 task done

Regression tests fail with python-consul 1.5.1 #3189

mbanck opened this issue Oct 19, 2024 · 0 comments · Fixed by #3191
Labels
bug

Comments

@mbanck
Copy link
Contributor

mbanck commented Oct 19, 2024 •
edited
Loading

What happened?

Debian unstable has upgraded python-consul from 0.7.1 to 1.5.1 recently, and since then the regression tests fail:
(see https://ci.debian.net/packages/p/patroni/testing/amd64/53163502/#S24):

2702s running test
2702s ============================= test session starts ==============================
2702s platform linux -- Python 3.12.6, pytest-8.3.3, pluggy-1.5.0 -- /usr/bin/python3
2702s cachedir: .pytest_cache
2702s rootdir: /tmp/autopkgtest-lxc.ji2ma5c6/downtmp/build.sB4/src
2702s plugins: cov-5.0.0, typeguard-4.3.0
2710s collecting ... collected 623 items / 2 errors
2710s 
2710s ==================================== ERRORS ====================================
2710s ____________________ ERROR collecting tests/test_consul.py _____________________
2710s tests/test_consul.py:88: in <module>
2710s     @patch.object(consul.Consul.KV, 'get', kv_get)
2710s E   AttributeError: type object 'Consul' has no attribute 'KV'
2710s ____________________ ERROR collecting tests/test_consul.py _____________________
2710s tests/test_consul.py:88: in <module>
2710s     @patch.object(consul.Consul.KV, 'get', kv_get)
2710s E   AttributeError: type object 'Consul' has no attribute 'KV'

How can we reproduce it (as minimally and precisely as possible)?

Use python-consul 1.5.1 for the regression tests

What did you expect to happen?

Regression tests pass

Patroni/PostgreSQL/DCS version

  • Patroni version: n/a (at least 3.3.2)
  • PostgreSQL version: n/a
  • DCS (and its version): consul, python3-consul 1.5.1

Patroni configuration file

n/a

patronictl show-config

n/a

Patroni log files

n/a

PostgreSQL log files

n/a

Have you tried to use GitHub issue search?

  • Yes

Anything else we need to know?

No response
@mbanck mbanck added the bug label Oct 19, 2024
CyberDem0n added a commit that referenced this issue Oct 21, 2024
@CyberDem0n
Switch to py-consul
f7232c7 
python-consul is unmaintained for a long time and py-consul is an
official replacement.
However, we still keep backward compatibility with python-consul.

Close: #3189
@CyberDem0n CyberDem0n mentioned this issue Oct 21, 2024
Merged
hughcapet pushed a commit that referenced this issue Nov 21, 2024
@CyberDem0n @hughcapet
Switch to py-consul (#3191)
65d7080 
python-consul is unmaintained for a long time and py-consul is an official replacement.
However, we still keep backward compatibility with python-consul.

Close: #3189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to py-consul patroni/patroni
1 participant
@mbanck