inspector: reduce InspectorIo API surface by eugeneo · Pull Request #28526 · nodejs/node · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: reduce InspectorIo API surface #28526

Closed
wants to merge 1 commit into from
Closed

inspector: reduce InspectorIo API surface #28526

wants to merge 1 commit into from

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Jul 3, 2019

This is a cleanup, allowing for a better separation of concerns.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 3, 2019
@eugeneo eugeneo requested a review from alexkozy July 3, 2019 18:13
@eugeneo eugeneo added the inspector Issues and PRs related to the V8 inspector protocol label Jul 3, 2019
@eugeneo
inspector: reduce InspectorIo API surface
71eb9af 
This is a cleanup, allowing for a better separation of concerns.
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24307/

@addaleax
Copy link
Member

addaleax commented Jul 6, 2019

Landed in 17862fc

@addaleax addaleax closed this Jul 6, 2019
addaleax pushed a commit that referenced this pull request Jul 6, 2019
@eugeneo @addaleax
inspector: reduce InspectorIo API surface
17862fc 
This is a cleanup, allowing for a better separation of concerns.

PR-URL: #28526
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2019
@eugeneo @targos
inspector: reduce InspectorIo API surface
66382ab 
This is a cleanup, allowing for a better separation of concerns.

PR-URL: #28526
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@alexkozy alexkozy alexkozy approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eugeneo @nodejs-github-bot @addaleax @alexkozy @Trott @BridgeAR