doc: drop 'for more details' in deprecations · nodejs/node@f688122 · GitHub
Skip to content

Commit

Permalink
doc: drop 'for more details' in deprecations
Browse files Browse the repository at this point in the history
The deprecations documentation links to the GitHub issue
tracker in several places. This commit makes the text
around those links consistent.

PR-URL: #28617
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
cjihrig authored and targos committed Jul 20, 2019
1 parent 29fda66 commit f688122
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ changes:
Type: End-of-Life

Calling an asynchronous function without a callback throws a `TypeError`
in Node.js 10.0.0 onwards. (See <https://github.com/nodejs/node/pull/12562>.)
in Node.js 10.0.0 onwards. See <https://github.com/nodejs/node/pull/12562>.

<a id="DEP0014"></a>
### DEP0014: fs.read legacy String interface
Expand Down Expand Up @@ -1754,8 +1754,8 @@ changes:
Type: End-of-Life
The AsyncHooks Sensitive API was never documented and had various minor issues.
(See <https://github.com/nodejs/node/issues/15572>.) Use the `AsyncResource`
API instead.
Use the `AsyncResource` API instead. See
<https://github.com/nodejs/node/issues/15572>.
<a id="DEP0086"></a>
### DEP0086: Remove runInAsyncIdScope
Expand All @@ -1774,8 +1774,7 @@ changes:
Type: End-of-Life
`runInAsyncIdScope` doesn't emit the `'before'` or `'after'` event and can thus
cause a lot of issues. See <https://github.com/nodejs/node/issues/14328> for
more details.
cause a lot of issues. See <https://github.com/nodejs/node/issues/14328>.
<a id="DEP0089"></a>
### DEP0089: require('assert')
Expand Down Expand Up @@ -1937,7 +1936,7 @@ to unrecoverable errors.
Use [`asyncResource.runInAsyncScope()`][] API instead which provides a much
safer, and more convenient, alternative. See
<https://github.com/nodejs/node/pull/18513> for more details.
<https://github.com/nodejs/node/pull/18513>.
<a id="DEP0099"></a>
### DEP0099: async context-unaware node::MakeCallback C++ APIs
Expand Down

0 comments on commit f688122

Please sign in to comment.