fix blank settings page by arvid220u · Pull Request #198261 · microsoft/vscode · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix blank settings page #198261

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix blank settings page #198261

merged 1 commit into from
Nov 15, 2023

Conversation

arvid220u
Copy link
Contributor

fixes #195722

the previous fix did not consider the case when no extension was returned

@rzhao271 rzhao271 added this to the November 2023 milestone Nov 15, 2023
@rebornix rebornix merged commit 0bc6184 into microsoft:main Nov 15, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

@bpasero bpasero bpasero approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.

Blank settings editor when having network issues
4 participants
@arvid220u @bpasero @rzhao271 @rebornix