Add support for running DebugConfigurations with serverReadyAction by WardenGnaw · Pull Request #197597 · microsoft/vscode · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for running DebugConfigurations with serverReadyAction #197597

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Add support for running DebugConfigurations with serverReadyAction #197597

merged 3 commits into from
Nov 22, 2023

Conversation

WardenGnaw
Copy link
Member

@WardenGnaw WardenGnaw commented Nov 6, 2023 •
edited
Loading

This PR adds 'config' as an option for serverReadyAction. It runs similar to 'name', but if a configuration is generated on the fly, its easier to inject the debug configurations with the serverReadyAction. This modifies the startNamedDebugSession to startDebugSession that takes in a vscode.DebugConfiguration.

Resolves: #186455

@roblourens
Copy link
Member

Did copilot write that 🤔

@WardenGnaw
Copy link
Member Author

The second half, yes 😅

I wanted to see what it would generate.

@WardenGnaw
Copy link
Member Author

The new AI generated summary with the new commit

This pull request to extensions/debug-server-ready adds a new feature that allows a debug configuration to be launched when the server is ready. The changes include modifications to the startNamedDebugSession method in extension.ts to use a new startDebugSession method that can take a debug configuration object as an argument, in addition to the debug configuration name. A new config property has been added to the ServerReadyAction interface to represent a debug configuration object that can be launched when the server is ready. These changes improve the flexibility and customization of debug sessions.

  • extensions/debug-server-ready/src/extension.ts: Modified the startNamedDebugSession method to use a new startDebugSession method that can take a debug configuration object as an argument, in addition to the debug configuration name. A new config property has been added to the ServerReadyAction interface to represent a debug configuration object that can be launched when the server is ready. (Fb352528)
  • extensions/debug-server-ready/package.json: Added a new debug configuration that can be launched when the server is ready, with properties such as configuration type, request type, and session termination included in the serverReadyAction array.

@WardenGnaw WardenGnaw force-pushed the dev/waan/serverReadyActionConfig branch from c4fff7c to 080452b Compare November 8, 2023 17:10
@WardenGnaw WardenGnaw force-pushed the dev/waan/serverReadyActionConfig branch from 080452b to 8bc92e6 Compare November 16, 2023 23:28
@WardenGnaw
Add support for running DebugConfigurations with serverReadyAction
72a314b 
This PR adds 'config' as an option for serverReadyAction. It runs
similar to 'name', but if a configuration is generated on the fly, its
easier to inject the debug configurations with the serverReadyAction.
@WardenGnaw
Merge into startDebugSession method
d303596
@WardenGnaw WardenGnaw force-pushed the dev/waan/serverReadyActionConfig branch from 8bc92e6 to d303596 Compare November 21, 2023 17:49
@WardenGnaw
Copy link
Member Author

@roblourens Is there anything else thats needs to be changed to get this PR merged?

@roblourens roblourens added this to the November 2023 milestone Nov 22, 2023
@roblourens roblourens enabled auto-merge (squash) November 22, 2023 19:37
@roblourens roblourens merged commit 452b754 into microsoft:main Nov 22, 2023
@WardenGnaw WardenGnaw deleted the dev/waan/serverReadyActionConfig branch November 22, 2023 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.

Extend serverReadyAction to support startDebugging with provided DebugConfiguration
3 participants
@WardenGnaw @roblourens @rzhao271