-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds "verified domain" identifier to url tooltip #197037
Conversation
@meganrogge Downloading the extension from the file doesn't bring over the "Verified" status. So I will need you to test this for me. I think this should fix it. However I am not extremely familiar with the codebase to know for sure if I'm in the right spot. |
thanks for working on this. In oss, I'm seeing it work when I verified.mov |
Interesting. Do you have any suggestions? I'm not sure if my fix changed the Aria label? |
I'll need to investigate more tomorrow. I'm not sure why it would work when focusing it in the backward tab order and not the forward. I haven't seen anything like that before. |
Sounds good. |
@sandy081 do you know why this would only work in one direction? could you pls test and see if you experience the same? |
@amaust given that, do you want to add this to the container's aria label too? |
Yep, sounds good |
Just for clarification @meganrogge, the container would be outside of the widget itself correct? If so do you know where I should look to find the container? |
Should be good to go now @meganrogge. |
On second thought, the verified domain will be indicated when the link is focused. I think that's what we want 👍🏼. We don't need to apply this to the container. |
closes #196876
Adds "Verified Domain" to the hover tooltip of Verified domain extension's marketplace pages.