Fix tsconfig resolution for navigation #192851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronakj
changed the title
|
@mjbvz can you take a look and approve these changes if they look ok? |
mjbvz
reviewed
Oct 5, 2023
| @@ -154,7 +154,7 @@ async function getTsconfigPath(baseDirUri: vscode.Uri, pathValue: string): Promi | |||
| return absolutePath; | |||
| } | |||
| return absolutePath.with({ | |||
| path: `${absolutePath.path}.json` | |||
| path: `${absolutePath.path}/tsconfig.json` | |||
There was a problem hiding this comment.
From https://github.com/microsoft/TypeScript/blob/febfd442cdba343771f478cf433b0892f213ad2f/src/compiler/commandLineParser.ts#L3005 I think we need to check both PATH.json and PATH/tsconfig.json, at least when resolving the path in extends
There was a problem hiding this comment.
Updated. From my own testing and looking at typescript documentation, extends and references are different in resolution. I have added a linkType parameter to the navigation command to resolve this, though we can also create a separate command if necessary.
mjbvz
approved these changes
Nov 6, 2023
lramos15
approved these changes
Nov 6, 2023
|
Thanks @ronakj! This will be in the next VS code insiders build |
amunger
pushed a commit
that referenced
this pull request
Nov 9, 2023
* Fix tsconfig resolution * Resolve based on link type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192772
Tested following scenarios -
node_modulesTested on Linux & Windows