Link to specific referenced subsection instead of containing article by wtoldt · Pull Request #36930 · mdn/content · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to specific referenced subsection instead of containing article #36930

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

wtoldt
Copy link
Contributor

@wtoldt wtoldt commented Nov 22, 2024

Description

A link referencing "Computed property names" could link to the specific subsection for the topic instead of the "Object initializer" article which contains it.

Motivation

I was reading the Strict mode > Duplicate property names section, followed the link to computed property names, and landed at the Object initializer page. I had to spend some time on the article before I realized there was a specific Computed property names subsection that I was looking for.

Additional details

The Strict mode > Duplicate property names section references computed property names, but does not directly link to the subsection. By linking directly to the subsection, readers can more quickly access the referenced material.

Related issues and pull requests

None that I am aware of.

A link referencing "Computed property names" could link to the specific heading for the topic instead of the greater article which contains it.
@wtoldt wtoldt requested a review from a team as a code owner November 22, 2024 20:14
@wtoldt wtoldt requested review from Josh-Cena and removed request for a team November 22, 2024 20:14
@github-actions github-actions bot added Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed labels Nov 22, 2024
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Josh-Cena Josh-Cena merged commit 5398feb into mdn:main Nov 22, 2024
7 checks passed
Copy link
Contributor

@wtoldt wtoldt deleted the patch-1 branch November 22, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants