Use RTI instead of real time · Issue #5 · mbalabash/estimo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RTI instead of real time #5

Open
ai opened this issue Apr 28, 2019 · 10 comments
Open

Use RTI instead of real time #5

ai opened this issue Apr 28, 2019 · 10 comments

Comments

@ai
Copy link
Contributor

ai commented Apr 28, 2019

There is a great idea to not track time, but track a CU ticks during JS execution

https://docs.google.com/presentation/d/1DutTpZ8p8K6JytEvNK1bJuvEIU3uMdhswwuZawdpuH0/edit#slide=id.g56184bbff6_0_93

Time is an unstable value, but CPU ticks will be always the same. Then we will multiple ticks with some factor to get the real time. It will make the time stable and usable as a limit. I will be an awesome feature.

According @aslushnikov idea https://twitter.com/aslushnikov/status/1121816765518897152?s=19

Related to #4
@ai
Copy link
Contributor Author

ai commented Apr 28, 2019 •
edited
Loading

@aslushnikov I can’t find in Tracium doc a way to get RTI. Can you help me?

@aslushnikov
Copy link

@ai upstream changes to Chromium aren't landed yet - are you building Chromium on your own?

@ai
Copy link
Contributor Author

ai commented Apr 29, 2019

@aslushnikov got it 😩. Any ETA when it will be in upstream? Or it is just an experimental branch?

@aslushnikov
Copy link

Any ETA when it will be in upstream?

@ai no ETA unfortunately

Or it is just an experimental branch?

No, it's not experimental. This patch is already LGTM'ed by one of the Chromium OWNERs, one more review is pending. Once all approves are cleared and comments are addressed, it'll land to the Chromium master branch.

@mbalabash
Copy link
Owner

Will wait 😴

New version of Estimo uses Tracium.
So, i hope we can add RTI as quickly as it support will be added in Tracium.

@mbalabash
Copy link
Owner

According to puppeteer/puppeteer#4591 Puppeteer can capture RTI by chrome traces on Linux platform.

@ai
Copy link
Contributor Author

ai commented Jun 19, 2019

Linux platform is enough. I will print a warning for non-Linux platform that data is not stable but will be stable on CI (we just need to be sure about the same numbers in both methods).

@aslushnikov in what stable version of Chrome we will have this feature? With Puppeter Core we now use Chrome on desktop machines.

@aslushnikov
Copy link

in what stable version of Chrome we will have this feature?

@ai the patch was landed in Chromium 77, which is scheduled to hit stable on Sep 10, 2019.

@mbalabash
Copy link
Owner

mbalabash commented Sep 25, 2019 •
edited
Loading

I prepared a puppeteer script according to puppeteer/puppeteer#4591 (comment).
But tidelta and ticount don't exist in trace file.

Here the issue.

@ai ai mentioned this issue Oct 4, 2019
Open
@mbalabash mbalabash mentioned this issue Nov 8, 2019
Open
@mbalabash
Copy link
Owner

If you are using Linux distro check this out to help me with testing this issue.

@ai ai mentioned this issue Jul 20, 2020
Closed
@atielking atielking mentioned this issue Sep 21, 2020
Closed
Repository owner deleted a comment from DylanZhu2021 Feb 23, 2024
Repository owner deleted a comment from DylanZhu2021 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ai @aslushnikov @mbalabash