Update 'Install all paid plugins at once' functionality and remove license key mgmt from Marketplace by michalkleiner · Pull Request #22237 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'Install all paid plugins at once' functionality and remove license key mgmt from Marketplace #22237

Merged
merged 19 commits into from
May 24, 2024
Merged

Update 'Install all paid plugins at once' functionality and remove license key mgmt from Marketplace #22237

merged 19 commits into from
May 24, 2024

Conversation

michalkleiner
Copy link
Contributor

@michalkleiner michalkleiner commented May 20, 2024 •
edited
Loading

Description

Changes done:

  • Remove license key management from Marketplace as this can be managed via settings.
  • Adjust styling for marketplace heading to prevent jumping of content on hover.
  • Update "Install all paid plugins at once" (IAPPAO) to fetch data from the controller to avoid a page refresh and be up to date.
  • Show plugin display names in update modal (instead of plugin names).
  • Simplify intro text for super users and non-super users as agreed on in JIRA.
  • Use pure CSS Matomo loader in the install button (discussed with design team). Already merged for reuse in 22240 🎉.
  • Limit width of the whole marketplace to 1300px similar to how it's done in the admin section as e.g. the install action takes the user from the dashboard marketplace to the admin marketplace and the UX would be inconsistent. This has been mentioned by product in the past and this ticket was a good candidate to adjust that.

Review

@michalkleiner michalkleiner added this to the 5.1.0 milestone May 20, 2024
@michalkleiner michalkleiner added c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. c: Design / UI For issues that impact Matomo's user interface or the design overall. javascript PRs that update Javascript code c: Premium plugins For bugs and features related to premium plugins. and removed c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. labels May 20, 2024
@michalkleiner michalkleiner force-pushed the DEV-17955-remove-license-section branch from 3e9161d to f9e126c Compare May 21, 2024 16:23
@michalkleiner michalkleiner mentioned this pull request May 22, 2024
Merged
11 tasks
@michalkleiner michalkleiner added the Needs Review PRs that need a code review label May 22, 2024
@michalkleiner michalkleiner requested a review from a team May 22, 2024 04:01
@michalkleiner michalkleiner force-pushed the DEV-17955-remove-license-section branch from 2a2e2e1 to fd2ef92 Compare May 22, 2024 21:46
@michalkleiner michalkleiner force-pushed the DEV-17955-remove-license-section branch from 1b52f75 to c7fc7f2 Compare May 24, 2024 06:57
@michalkleiner michalkleiner requested review from mneudert and a team May 24, 2024 06:57
@michalkleiner michalkleiner merged commit 93ec0c7 into 5.x-dev May 24, 2024
19 of 25 checks passed
@michalkleiner michalkleiner deleted the DEV-17955-remove-license-section branch May 24, 2024 12:24
@mneudert mneudert mentioned this pull request May 27, 2024
Merged
11 tasks
@sgiehl sgiehl changed the title [DEV-17955] Update 'Install all paid plugins at once' functionality and remove license key mgmt from Marketplace Update 'Install all paid plugins at once' functionality and remove license key mgmt from Marketplace May 28, 2024
valentinab25 pushed a commit to valentinab25/matomo that referenced this pull request Jan 27, 2025
@michalkleiner @valentinab25
[DEV-17955] Update 'Install all paid plugins at once' functionality a…
5c8094e 
…nd remove license key mgmt from Marketplace (matomo-org#22237)

* Remove license key fields from marketplace and update 'Install all paid plugins at once' functionality
* Increase space between marketplace intro and plugins list filters
* Prevent showing install button when not valid consumer or not super user
* Remove unused translations, components, styles
* Adjust Install all paid plugins button behaviour to show loading disabled state when waiting for server response
* Update UI test screenshots
* Add UI tests for the Install all paid plugins button
* Remove superfluous UI tests after removing license key section from Marketplace overview
* Move 'Install all paid plugins modal' test to start free trial test suite
* Simplify UI tests and update screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. c: Premium plugins For bugs and features related to premium plugins. javascript PRs that update Javascript code Needs Review PRs that need a code review
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michalkleiner @mneudert