Fix: skipping a Tour challenge shows an error message by sgiehl · Pull Request #22231 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: skipping a Tour challenge shows an error message #22231

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 17, 2024

Description:

When clicking the skip icon in the Tour widget, a notification gets displayed that there was a problem with the request.
Actually the request is processed correctly, but it lacks the format parameter, causing XML to be returned instead of the expected JSON.

fixes L3-721

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label May 17, 2024
@sgiehl sgiehl added this to the 5.1.0 milestone May 17, 2024
@sgiehl sgiehl requested a review from a team May 17, 2024 12:26
@mneudert mneudert merged commit 54554f5 into 5.x-dev May 17, 2024
22 of 25 checks passed
@mneudert mneudert deleted the L3-721 branch May 17, 2024 13:19
valentinab25 pushed a commit to valentinab25/matomo that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants