Replace usage of SQL_CALC_FOUND_ROWS with separate queries #22225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't see it from the PR itself — how is the change around the headers related to the SQL_CALC_FOUND_ROWS? |
|
The API does not return the count directly but sends it with a header. The changes are only to make that header testable in the API tests. |
mneudert
approved these changes
May 17, 2024
valentinab25
pushed a commit
to valentinab25/matomo
that referenced
this pull request
Jan 27, 2025
…g#22225) * Adjust tests to check for result count header * Use separate query instead of SQL_CALC_FOUND_ROWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With MySQL 8.0.17 the
SQL_CALC_FOUND_ROWSfeature has been deprecated.To ensure we stay compatible with upcoming MySQL releases, where this might be removed, this PR replaces all usages with separate queries to fetch the count.
Review