Allow users to request a premium feature trial #22139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
force-pushed
the
dev-17986
branch
3 times, most recently
from
d5e94a0 to
8998da8
Compare
sgiehl
added
Enhancement
sgiehl
force-pushed
the
dev-17986
branch
4 times, most recently
from
13c23f5 to
c780fd7
Compare
mneudert
reviewed
Apr 25, 2024
* Implement hash param to trigger new plugin overlay * Update plugins/Marketplace/vue/src/PluginList/PluginList.vue --------- Co-authored-by: Marc Neudert <marc@innocraft.com>
11 tasks
valentinab25
pushed a commit
to valentinab25/matomo
that referenced
this pull request
Jan 27, 2025
* Allow users to request a trial for a premium plugin * Update expected screenshots * Implement plugin trial notification * Change button if trial was already requested * use correct notification message * restructure code * use DI in API * fix possible problem with non alphanum userlogins * code cleanup & tests * Add UI tests for dismissable notification * Disable trial requests when config set to -1 * disallow trial requests for super users again * Automatically cancel/remove a plugin trial request when the plugin is installed * test debug * Properly clean up trial request confirmation state on close * Use plugin display name for all trial related frontend dialogs/notifications * use plugin display name in email * Allow trial request from plugin details modal * store plugin display name for notifications * Use more resilient action/event state passing * Update expected screenshots * Build vue components * don't sanitize api parameters for requestTrial * Ensure plugin name in email is escaped * Fix tests * Implement hash param to trigger new plugin overlay (matomo-org#22167) * Implement hash param to trigger new plugin overlay * Update plugins/Marketplace/vue/src/PluginList/PluginList.vue --------- Co-authored-by: Marc Neudert <marc@innocraft.com> * Build vue files * Update trial request notification plugin display name expectations --------- Co-authored-by: Marc Neudert <marc@innocraft.com> Co-authored-by: mneudert <mneudert@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Non super users will now be allowed to request the trial of a premium feature.
When a request is sent all super users will receive an email. In addition a notification will be displayed to every super user.
Every request by default has an expiration time of 27 days. This can be configured using config flag
plugin_trial_request_expiration_in_days. If no superuser installs the plugin, no user can request a plugin trial again for the same plugin until the previous request expired.Setting the config flag to -1 will completely disable plugin trial requests.
Notifications for super users can be dismissed. When this is done they won't be shown again for this specific super user. Other super users will still see it until they dismiss it. Dismissing notifications won't impact expiration time. So even if every super user dismisses the notification a new request will first be possible when the request expired.
Review