Ignore anonymous user when checking for allowed domains by sgiehl · Pull Request #22044 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore anonymous user when checking for allowed domains #22044

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 25, 2024

Description:

Matomo allows to configure allowed email domains. Only email addresses that matches those domains can then be used.
To avoid any current users to become "invalid" the list always needs to contain all domains for existent users.
This at the moment also contains the domain of the automatically created anonymous user, which is example.org. As it doesn't make sense to always allow addresses for this domain only because of the anonymous user, this PR changes the code, so the anonymous user's email domain is ignored for this setting and checks.

fixes #22009

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Mar 25, 2024
@sgiehl sgiehl added this to the 5.1.0 milestone Mar 25, 2024
@sgiehl sgiehl requested a review from a team March 25, 2024 13:54
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgiehl sgiehl merged commit 9318db0 into 5.x-dev Mar 26, 2024
21 of 25 checks passed
@sgiehl sgiehl deleted the m22009 branch March 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] UsersManager: can't disallow example.org as email domain
2 participants