Ignore anonymous user when checking for allowed domains #22044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Matomo allows to configure allowed email domains. Only email addresses that matches those domains can then be used.
To avoid any current users to become "invalid" the list always needs to contain all domains for existent users.
This at the moment also contains the domain of the automatically created
anonymous
user, which isexample.org
. As it doesn't make sense to always allow addresses for this domain only because of the anonymous user, this PR changes the code, so the anonymous user's email domain is ignored for this setting and checks.fixes #22009
Review