Add more visually striking marketplace menu item in sidebar #21512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar (#21456) * Fix CS * Fix typo in UI demo example * Add styling and UI demo example for outline button (with reverse bg on hover) * Remove premium features widget * Allow category to have a custom widget for the reporting menu * Implement marketplace rich menu button * Remove surplus category config * Build vue files * Update unit tests with an empty category widget prop * Update system test expected files * Add type hints * Update UI test screenshots * Update expected API response xml * Partially revert "Remove premium features widget" This reverts commit 5f37b02. We are not reverting the removal of the subcategory. * built vue files * Restore Paid Plugins widget in system test expected files Partially reverts commit c351ec9. * Update expected test files * Use data attribute instead of CSS class * Add tabindex * Build vue files * built vue files * Let category load when there's exactly one subcategory or multiple subcategories and an override widget * Add support for keyboard submit * Build vue files * Update quick access search UI test screenshot PM is ok with the menu items being removed from the quick access menu. Keyboard access to the new rich menu button works. * Update built vue files --------- Co-authored-by: michalkleiner <michalkleiner@users.noreply.github.com>
caddoo
force-pushed
the
dev-17234-marketplace-menu-backport
branch
from
47df8c3
to
98c0733
Compare
bx80
suggested changes
Nov 10, 2023
There was a problem hiding this comment.
Were we expecting a change here? The layout seems to have moved up by a couple of pixels.
There was a problem hiding this comment.
Nope, I've reverted now, and can confirm this is a flaky test within testomat
There was a problem hiding this comment.
Nope, I've reverted now, and can confirm this is a flaky test within testomat
There was a problem hiding this comment.
The marketplace entry now seems to be missing from the quick access search.
There was a problem hiding this comment.
That is accepted/expected for now was discussed between @michalkleiner and @Stan-vw already.
bx80
approved these changes
Nov 10, 2023
sgiehl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
#21456
Tested locally, updated and looked through all UI tests that failed and recommitted because of the differences between 4 and 5.
Description:
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Review