Allow social & search definitions to be sourced locally #18023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Sep 17, 2021
config/global.ini.php
Outdated
| @@ -833,6 +833,10 @@ | |||
| ; If set to 1, when rearchiving reports in the past we do not rearchive segment data with those reports. Default is 0. | |||
| rearchive_reports_in_past_exclude_segments = 0 | |||
|
|
|||
| ; If set to 1, then social and search engine definitions files will be downloaded from Matomo remotely to update | |||
There was a problem hiding this comment.
These are actually downloaded from github see https://github.com/matomo-org/matomo/blob/4.4.1/plugins/Referrers/Tasks.php#L33-L49 and not from Matomo. This is something we need to improve in the future to "proxy" or serve them through Matomo servers.
There was a problem hiding this comment.
@tsteur Thanks for that. I've made a change based on your suggestion :)
tsteur
added a commit
to matomo-org/matomo-for-wordpress
that referenced
this pull request
Sep 20, 2021
refs matomo-org/matomo#18023 still keeping additionally though the checks to just ignore the tasks in https://github.com/matomo-org/matomo-for-wordpress/blob/4.4.2/plugins/WordPress/WordPress.php#L113-L114 just to make sure they won't be executed
sgiehl
reviewed
Sep 21, 2021
sgiehl
reviewed
Sep 21, 2021
tsteur
deleted the
idev2088-addSettingLoadCoreSocialSearchDefinitions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issue: DEV-2088
Introduced functionality:
This change allows Matomo to source search + social definitions yaml files locally, instead of reading them from remotely sourced updates.
If the introduced configuration variable is changed to 0 (false) then it will only ever load social and search definitions from the local YML files packaged with Matomo.
Existing behavior
How it works at the moment is that a weekly task will fetch the latest definition files from Matomo github. It will store this in the the Option table and retrieve it from the option table when definitions are requested and there is a cache miss.
Review