Fix possible notices by sgiehl · Pull Request #17886 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible notices #17886

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Fix possible notices #17886

merged 2 commits into from
Aug 16, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 13, 2021

Description:

fixes #17883

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Aug 13, 2021
@sgiehl sgiehl added this to the 4.5.0 milestone Aug 13, 2021
@sgiehl sgiehl requested a review from diosmosis August 16, 2021 10:20
@diosmosis diosmosis merged commit 8c7fa7d into 4.x-dev Aug 16, 2021
@diosmosis diosmosis deleted the fixnotices branch August 16, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

Possible warning notices during log archive
2 participants
@sgiehl @diosmosis