allow multiple calls to enableLinkTracking #17101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, would be good to have a test for it in tests/javascript/index.php |
|
build js |
|
👍 indeed it can be called multiple times |
|
It would be great if someone else could create the test as I don't have a great overview over tests/javascript/index.php and not enough time to more closely look into it. |
|
@Findus23 I reckon it's fine it wouldn't need a test and be quite hard to test actually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if I understand the issue correctly, but I think it should be possible to call
enableLinkTrackingmultiple times.reported in https://forum.matomo.org/t/enablelinktracking-re-scan-dom-after-content-changes/40269
Review