wrong escaping of cookie path #16087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be something we maybe should add to 3.x-dev. Seems to be the same issue we had with session cookies. See #15602 |
Findus23
added
the
Regression
|
Haven't looked... can we always trust the |
|
@tsteur In most cases it should use config values for |
|
👍 sweet. Was just meaning in case there is user input somewhere we'd need to do maybe some validation or so. That's all. |
|
👍 to merge into 3.x-dev |
diosmosis
pushed a commit
that referenced
this pull request
Jun 25, 2020
Co-authored-by: michael.heerklotz <michael.heerklotz@check24.de>
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this commit has been merged, setting the cookie path is broken.
3b69290
#15185
Cookie path in the Set-Cookie header must not be escaped, or the browser will fall back to the current URL path.
For example:
If $Path === '/' and the cookie is set from /js/tracker.php, the browser will save the cookie path as "/js" and not "/".
Reading the docu here https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie, I think we should not escape the path at all.
Same applies for the domain, but since the dot is not escaped by rawurlencode, I think it does not hurt